| Message ID | 20180918133434.27437-1-amir73il@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Assorted overlayfs fixes for 4.19-rc5 | expand |
On Tue, Sep 18, 2018 at 4:34 PM Amir Goldstein <amir73il@gmail.com> wrote: > > Miklos, > > Found one memory leak that needs a fix for stable and > two missing freeze protections in stacked f_ops. > > Last patch is not a bugfix, but it fixes a trap that we set > for developers back in v4.10 - and you happened to step into. > > The series passed xfstests -g quick with overlayfs over > xfs and ext4 and the usual unionmount testsuite torture. > > The memory leak was detected with tests overlay/051,053 > after I enabled kmemleak on my test setup. > Miklos, Maybe not enough time has passed to justify a PING, but you know I get edgy towards the end of a release cycle, especially a weird release cycle as this one... P.S. removing Al from CC because his emails have been bouncing. Al, are you there? Thanks, Amir.
On Mon, Sep 24, 2018 at 10:25 AM, Amir Goldstein <amir73il@gmail.com> wrote: > On Tue, Sep 18, 2018 at 4:34 PM Amir Goldstein <amir73il@gmail.com> wrote: >> >> Miklos, >> >> Found one memory leak that needs a fix for stable and >> two missing freeze protections in stacked f_ops. >> >> Last patch is not a bugfix, but it fixes a trap that we set >> for developers back in v4.10 - and you happened to step into. >> >> The series passed xfstests -g quick with overlayfs over >> xfs and ext4 and the usual unionmount testsuite torture. >> >> The memory leak was detected with tests overlay/051,053 >> after I enabled kmemleak on my test setup. >> > > Miklos, > > Maybe not enough time has passed to justify a PING, but you know I get > edgy towards the end of a release cycle, especially a weird release cycle as > this one... Thanks for the reminder. Pushed to overlayfs-next and will ask Greg to pull before -rc6. If I forget, please remind again ;) Thanks, Miklos
Miklos, Found one memory leak that needs a fix for stable and two missing freeze protections in stacked f_ops. Last patch is not a bugfix, but it fixes a trap that we set for developers back in v4.10 - and you happened to step into. The series passed xfstests -g quick with overlayfs over xfs and ext4 and the usual unionmount testsuite torture. The memory leak was detected with tests overlay/051,053 after I enabled kmemleak on my test setup. Thanks, Amir. Amir Goldstein (4): ovl: fix memory leak on unlink of indexed file ovl: fix freeze protection bypass in ovl_write_iter() ovl: fix freeze protection bypass in ovl_clone_file_range() vfs: swap names of {do,vfs}_clone_file_range() fs/ioctl.c | 2 +- fs/nfsd/vfs.c | 3 ++- fs/overlayfs/copy_up.c | 2 +- fs/overlayfs/file.c | 2 ++ fs/overlayfs/util.c | 3 ++- fs/read_write.c | 17 +++++++++++++++-- include/linux/fs.h | 17 +++-------------- 7 files changed, 26 insertions(+), 20 deletions(-)