mbox series

[v3,00/13] add the latest exfat driver

Message ID 20191119093718.3501-1-namjae.jeon@samsung.com (mailing list archive)
Headers show
Series add the latest exfat driver | expand

Message

Namjae Jeon Nov. 19, 2019, 9:37 a.m. UTC 
This adds the latest Samsung exfat driver to fs/exfat. This is an
implementation of the Microsoft exFAT specification. Previous versions
of this shipped with millions of Android phones, an a random previous
snaphot has been merged in drivers/staging/.

Compared to the sdfat driver shipped on the phones the following changes
have been made:

 - the support for vfat has been removed as that is already supported
   by fs/fat
 - driver has been renamed to exfat
 - the code has been refactored and clean up to fully integrate into
   the upstream Linux version and follow the Linux coding style
 - metadata operations like create, lookup and readdir have been further
   optimized
 - various major and minor bugs have been fixed

We plan to treat this version as the future upstream for the code base
once merged, and all new features and bug fixes will go upstream first.

v3:
 - fix wrong sbi->s_dirt set.

v2:
 - Check the bitmap count up to the total clusters.
 - Rename proper goto labels in seveal place.
 - Change time mode type with enumeration.
 - Directly return error instead of goto at first error check.
 - Combine seq_printfs calls into a single one.

Namjae Jeon (13):
  exfat: add in-memory and on-disk structures and headers
  exfat: add super block operations
  exfat: add inode operations
  exfat: add directory operations
  exfat: add file operations
  exfat: add exfat entry operations
  exfat: add bitmap operations
  exfat: add exfat cache
  exfat: add misc operations
  exfat: add nls operations
  exfat: add Kconfig and Makefile
  exfat: add exfat in fs/Kconfig and fs/Makefile
  MAINTAINERS: add exfat filesystem

 MAINTAINERS          |    7 +
 fs/Kconfig           |    3 +-
 fs/Makefile          |    1 +
 fs/exfat/Kconfig     |   21 +
 fs/exfat/Makefile    |    8 +
 fs/exfat/balloc.c    |  271 ++++++++
 fs/exfat/cache.c     |  325 +++++++++
 fs/exfat/dir.c       | 1338 +++++++++++++++++++++++++++++++++++++
 fs/exfat/exfat_fs.h  |  534 +++++++++++++++
 fs/exfat/exfat_raw.h |  190 ++++++
 fs/exfat/fatent.c    |  475 ++++++++++++++
 fs/exfat/file.c      |  346 ++++++++++
 fs/exfat/inode.c     |  691 +++++++++++++++++++
 fs/exfat/misc.c      |  247 +++++++
 fs/exfat/namei.c     | 1492 ++++++++++++++++++++++++++++++++++++++++++
 fs/exfat/nls.c       |  817 +++++++++++++++++++++++
 fs/exfat/super.c     |  752 +++++++++++++++++++++
 17 files changed, 7517 insertions(+), 1 deletion(-)
 create mode 100644 fs/exfat/Kconfig
 create mode 100644 fs/exfat/Makefile
 create mode 100644 fs/exfat/balloc.c
 create mode 100644 fs/exfat/cache.c
 create mode 100644 fs/exfat/dir.c
 create mode 100644 fs/exfat/exfat_fs.h
 create mode 100644 fs/exfat/exfat_raw.h
 create mode 100644 fs/exfat/fatent.c
 create mode 100644 fs/exfat/file.c
 create mode 100644 fs/exfat/inode.c
 create mode 100644 fs/exfat/misc.c
 create mode 100644 fs/exfat/namei.c
 create mode 100644 fs/exfat/nls.c
 create mode 100644 fs/exfat/super.c

Comments

Markus Elfring Nov. 19, 2019, 12:15 p.m. UTC | #1 
> …, an a random previous

Does this wording contain a typo?


> We plan to treat this version as the future upstream for the code base
> once merged, and all new features and bug fixes will go upstream first.

Were the following mentioned issues occasionally reviewed already
by other developers before?


> v3:
>  - fix wrong sbi->s_dirt set.
>
> v2:
>  - Check the bitmap count up to the total clusters.
>  - Rename proper goto labels in seveal place.

Would you like to avoid further typos in such change descriptions?


>  - Change time mode type with enumeration.

How do you think about to increase the usage of enumerations
at any more source code places?


>  - Directly return error instead of goto at first error check.
>  - Combine seq_printfs calls into a single one.

Please refer to the correct function name.


Thanks for your positive feedback.

Regards,
Markus
Namjae Jeon Nov. 19, 2019, 12:43 p.m. UTC | #2 
2019-11-19 21:15 GMT+09:00, Markus Elfring <Markus.Elfring@web.de>:
>> …, an a random previous
>
> Does this wording contain a typo?
Yes, Will fix it on next series.

>
>
>> We plan to treat this version as the future upstream for the code base
>> once merged, and all new features and bug fixes will go upstream first.
>
> Were the following mentioned issues occasionally reviewed already
> by other developers before?
https://marc.info/?l=linux-fsdevel&m=156985252507812&w=2

>
>
>> v3:
>>  - fix wrong sbi->s_dirt set.
>>
>> v2:
>>  - Check the bitmap count up to the total clusters.
>>  - Rename proper goto labels in seveal place.
>
> Would you like to avoid further typos in such change descriptions?
Will fix on next series.
>
>
>>  - Change time mode type with enumeration.
>
> How do you think about to increase the usage of enumerations
> at any more source code places?
I will check.
>
>
>>  - Directly return error instead of goto at first error check.
>>  - Combine seq_printfs calls into a single one.
>
> Please refer to the correct function name.
Okay:)
>
>
> Thanks for your positive feedback.
Thanks for your review!
>
> Regards,
> Markus
>