From patchwork Mon Dec 23 21:08:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sargun Dhillon X-Patchwork-Id: 11308757 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5507A138D for ; Mon, 23 Dec 2019 21:08:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E321206CB for ; Mon, 23 Dec 2019 21:08:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=sargun.me header.i=@sargun.me header.b="KYeJkAS8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726840AbfLWVI3 (ORCPT ); Mon, 23 Dec 2019 16:08:29 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:40633 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726832AbfLWVI3 (ORCPT ); Mon, 23 Dec 2019 16:08:29 -0500 Received: by mail-io1-f66.google.com with SMTP id x1so17368695iop.7 for ; Mon, 23 Dec 2019 13:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sargun.me; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=2PRppcZj4QQV2bYtw/LlSv6wKSsTQE8fDROQNhRtfik=; b=KYeJkAS8Z8H02AKtkskQnaPjMQKy1JBE6L0dadg7nnYeXthIYm+RIEc1R1faHZtU5u MIdgJ/Xtp9suaQ5iEwrIhl2BQxuuGQbQQZaAZqM8ct1CqqMnb2EUv8wgHl2ctlR2q2NO n5Kaeqj2vKcwmb4jpqSxGUW2aR/UOANVHXTuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=2PRppcZj4QQV2bYtw/LlSv6wKSsTQE8fDROQNhRtfik=; b=XA8X17ABrcvUiEGCA45zD3iUm6pI9vCE9rgfaSoDv0Cmm+na1AdD2l0vp0xUi64zwi igoLVr8K6IlQdpeF36dYz4clOSnTA5uqrK2h1sHQ9aWNp480D29XLQmrvJ3Iy3tLT831 FHCduNQ3kClb2SyfKZ7qg6G4XepDr++1iG+mku73iTuxOhBDq2yYLEeV+9hSbpw9G4z3 HVYHlSkoBFFkHSyZdp5fU7e2RV8UCdAfRjqfjHTTAkb7G3QUyC0+kNEA3bG93aEhzXho 05izIdP8iexc4GQepYBcr/Mdjwcv90GwBfFD6cFL6HLra3SUBpCdBwhvVUfgNIqPQKNv F68Q== X-Gm-Message-State: APjAAAU5bSgOUcBB/h81Qj1DHmPJjXc8rNMzTLu3NMrT/pdDhSblU5eS cIk4mZlpd9wFhvEMMM/fjntLDQ== X-Google-Smtp-Source: APXvYqxWC8XJxbsYgVo33DCabCchrWq0s88ACsLTW88a+abxzD48tfSdHvrYrnPPlxNtsXSoraUiww== X-Received: by 2002:a02:b893:: with SMTP id p19mr24549440jam.103.1577135308072; Mon, 23 Dec 2019 13:08:28 -0800 (PST) Received: from ircssh-2.c.rugged-nimbus-611.internal (80.60.198.104.bc.googleusercontent.com. [104.198.60.80]) by smtp.gmail.com with ESMTPSA id p5sm9312687ilg.69.2019.12.23.13.08.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Dec 2019 13:08:27 -0800 (PST) Date: Mon, 23 Dec 2019 21:08:26 +0000 From: Sargun Dhillon To: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: tycho@tycho.ws, jannh@google.com, cyphar@cyphar.com, christian.brauner@ubuntu.com, oleg@redhat.com, luto@amacapital.net, viro@zeniv.linux.org.uk, gpascutto@mozilla.com, ealvarez@mozilla.com, fweimer@redhat.com, jld@mozilla.com, arnd@arndb.de Subject: [PATCH v6 0/3] Add pidfd_getfd syscall Message-ID: <20191223210823.GA25083@ircssh-2.c.rugged-nimbus-611.internal> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org This patchset introduces a mechanism (pidfd_getfd syscall) to get file descriptors from other processes via pidfd. Although this can be achieved using SCM_RIGHTS, and parasitic code injection, this offers a more straightforward mechanism, with less overhead and complexity. The process under manipulation's fd still remains valid, and unmodified by the copy operation. It introduces a flags field. The flags field is reserved a the moment, but the intent is to extend it with the following capabilities: * Close the remote FD when copying it * Drop the cgroup data if it's a fd pointing a socket when copying it The syscall numbers were chosen to be one greater than openat2. Summary of history: This initially started as a ptrace command. It did not require the process to be stopped, and felt like kind of an awkward fit for ptrace. After that, it moved to an ioctl on the pidfd. Given functionality, it made sense to make it a syscall which did not require the process to be stopped. Changes since v5: * Drop pidfd_getfd_options struct and replace with a flags field Changes since v4: * Turn into a syscall * Move to PTRACE_MODE_ATTACH_REALCREDS from PTRACE_MODE_READ_REALCREDS * Remove the sample code. This will come in another patchset, as the new self-tests cover all the functionality. Changes since v3: * Add self-test * Move to ioctl passing fd directly, versus args struct * Shuffle around include files Changes since v2: * Move to ioctl on pidfd instead of ptrace function * Add security check before moving file descriptor Changes since the RFC v1: * Introduce a new helper to fs/file.c to fetch a file descriptor from any process. It largely uses the code suggested by Oleg, with a few changes to fix locking * It uses an extensible options struct to supply the FD, and option. * I added a sample, using the code from the user-ptrace sample Sargun Dhillon (3): vfs, fdtable: Add get_task_file helper pid: Introduce pidfd_getfd syscall test: Add test for pidfd getfd arch/alpha/kernel/syscalls/syscall.tbl | 1 + arch/arm/tools/syscall.tbl | 1 + arch/arm64/include/asm/unistd.h | 2 +- arch/arm64/include/asm/unistd32.h | 2 + arch/ia64/kernel/syscalls/syscall.tbl | 1 + arch/m68k/kernel/syscalls/syscall.tbl | 1 + arch/microblaze/kernel/syscalls/syscall.tbl | 1 + arch/mips/kernel/syscalls/syscall_n32.tbl | 1 + arch/mips/kernel/syscalls/syscall_n64.tbl | 1 + arch/mips/kernel/syscalls/syscall_o32.tbl | 1 + arch/parisc/kernel/syscalls/syscall.tbl | 1 + arch/powerpc/kernel/syscalls/syscall.tbl | 1 + arch/s390/kernel/syscalls/syscall.tbl | 1 + arch/sh/kernel/syscalls/syscall.tbl | 1 + arch/sparc/kernel/syscalls/syscall.tbl | 1 + arch/x86/entry/syscalls/syscall_32.tbl | 1 + arch/x86/entry/syscalls/syscall_64.tbl | 1 + arch/xtensa/kernel/syscalls/syscall.tbl | 1 + fs/file.c | 22 +- include/linux/file.h | 2 + include/linux/syscalls.h | 1 + include/uapi/asm-generic/unistd.h | 3 +- kernel/pid.c | 106 ++++++++ tools/testing/selftests/pidfd/.gitignore | 1 + tools/testing/selftests/pidfd/Makefile | 2 +- .../selftests/pidfd/pidfd_getfd_test.c | 253 ++++++++++++++++++ 26 files changed, 405 insertions(+), 5 deletions(-) create mode 100644 tools/testing/selftests/pidfd/pidfd_getfd_test.c