From patchwork Sun Mar 15 09:53:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yafang Shao X-Patchwork-Id: 11438735 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1891414E5 for ; Sun, 15 Mar 2020 07:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E260F20722 for ; Sun, 15 Mar 2020 07:53:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cipyPITv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727448AbgCOHw7 (ORCPT ); Sun, 15 Mar 2020 03:52:59 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35812 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727134AbgCOHw7 (ORCPT ); Sun, 15 Mar 2020 03:52:59 -0400 Received: by mail-pg1-f195.google.com with SMTP id 7so7729314pgr.2 for ; Sun, 15 Mar 2020 00:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Q6FJASjtZqzOalHsgC8qcYtZ8TkZFFYx7Anoq682QsM=; b=cipyPITvIndnMqeBhyZulRA3kH44VIccHvDGc/5CMJY/f1BZRe1aiXVQPg5yiG7bKh ndpnXGEdVANXgHitFOw0N4oAwt6IEyIq/LVvrSiBWxqW2t4BQkmMgmfpnomsF+QwJIl3 lIA2p3LvSvzXEil9IRrm+q3OZaN7TRpYIEBoSOa1PX26J93gR3fNWRvj5qO/WO+OenNH us7pwQX0w9LTqpRSr1hLNR5LPcykiqg3vMrJus9xKFmS7Oj87CY71CKPFCGckepE3kPu N/2X91nhguCz8T1kySWWFSLBTvG/VDLr659MFc6NN1HPB+eQfkJJhfkUoxl1wrOCJOl2 XEjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q6FJASjtZqzOalHsgC8qcYtZ8TkZFFYx7Anoq682QsM=; b=ERP2J0uOr+pOjAlAiPnxixQeUEUWuWJV6s7g1wohtqvMuC5SRM/HMT7tAM2IVVEC1o 65v6iCkYwZ5DejiFD8p861X+w9NJqWNYEviNl9djQ+ty+ecyPYnBZyOIUScANmZN6d4g a0cQ0oqCcgQBwJWkU6eXnUaiim/UKtLAnQZ+/wch77IIWAW8/dVvLvey4odAmTm3cYUe 8/6kMRqp2oHmu00rdcpkc2R02834Nn8ByP+m7qALbOFu4YgP4c2t+2nxy056tHITCIdH eVGUhQvi1KBCvGKoy5piUkskdrT5OD9MAkdZr36fzm5hJT+/HX4x5jNV9vnAsTlDqee1 9Q0w== X-Gm-Message-State: ANhLgQ3ZlObFG4w153RRZMEdDm36tU7vpsQrEFFy4Ltle2SIdeeiCw6I 71vLBS7bsoWC1gwOnlV+ngw= X-Google-Smtp-Source: ADFU+vuu3cQLjgWFHfdSNe+9QhP5epW7bLGxVnj+uHynyCSBR1iSiGRqigSE3tPCYSLNMmDJtqaXRA== X-Received: by 2002:a63:384e:: with SMTP id h14mr20869866pgn.295.1584258777498; Sun, 15 Mar 2020 00:52:57 -0700 (PDT) Received: from master.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id w11sm62592984pfn.4.2020.03.15.00.52.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Mar 2020 00:52:56 -0700 (PDT) From: Yafang Shao To: dchinner@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, guro@fb.com, akpm@linux-foundation.org, viro@zeniv.linux.org.uk Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Yafang Shao Subject: [PATCH v5 0/3] protect page cache from freeing inode Date: Sun, 15 Mar 2020 05:53:39 -0400 Message-Id: <20200315095342.10178-1-laoar.shao@gmail.com> X-Mailer: git-send-email 2.14.1 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On my server there're some running MEMCGs protected by memory.{min, low}, but I found the usage of these MEMCGs abruptly became very small, which were far less than the protect limit. It confused me and finally I found that was because of inode stealing. Once an inode is freed, all its belonging page caches will be dropped as well, no matter how may page caches it has. So if we intend to protect the page caches in a memcg, we must protect their host (the inode) first. Otherwise the memcg protection can be easily bypassed with freeing inode, especially if there're big files in this memcg. The inherent mismatch between memcg and inode is a trouble. One inode can be shared by different MEMCGs, but it is a very rare case. If an inode is shared, its belonging page caches may be charged to different MEMCGs. Currently there's no perfect solution to fix this kind of issue, but the inode majority-writer ownership switching can help it more or less. After this patch, it may take extra time to skip these inodes when workload outside of a memcg protected by memory.min or memory.low is trying to do page reclaim, especially if there're lots of inodes pinned by pagecache in this protected memcg. In order to measure the potential regressions, I constructed bellow test case on my server. My server is a machine with two nodes, and each of these nodes has 64GB memory. I created two memcgs, and memory.low of these memcgs are both set with 1G. Then I generated more than 500 thousand inodes in each of them, and pagacaches of these inodes are from 4K to 4M. IOW, there're totally more than 1 million xfs_inode in the memory and the total pagecache of them are nearly 128GB. Then I run a workload outside of these two protected memcgs. That workload is usemem in Mel's mmtests with a little modification to alloc almost all the memory and iterate only once. Bellow is the compared result of the Amean of elapsed time and sys%. 5.6.0-rc4 patched Amean syst-4 65.75 ( 0.00%) 68.08 * -3.54%* Amean elsp-4 32.14 ( 0.00%) 32.63 * -1.52%* Amean syst-7 67.47 ( 0.00%) 66.71 * 1.13%* Amean elsp-7 19.83 ( 0.00%) 18.41 * 7.16%* Amean syst-12 98.27 ( 0.00%) 99.29 * -1.04%* Amean elsp-12 15.60 ( 0.00%) 16.00 * -2.56%* Amean syst-21 174.69 ( 0.00%) 172.92 * 1.01%* Amean elsp-21 14.63 ( 0.00%) 14.75 * -0.82%* Amean syst-30 195.78 ( 0.00%) 205.90 * -5.17%* Amean elsp-30 12.42 ( 0.00%) 12.73 * -2.50%* Amean syst-40 249.85 ( 0.00%) 250.81 * -0.38%* Amean elsp-40 12.19 ( 0.00%) 12.25 * -0.49%* I did many times. Each time I run this test, I got different result. But the differece is not too big. Furthmore, this behavior only occurs when memory.min or memory.low is set, and the user already knows that memory.{min, low} can protect the pages at the cost of taking more CPU times, so small extra time is expected by the user. While if the workload trying to reclaim these protected inodes is inside of a protected memcg, then this workload will not be effected at all because memory.{min, low} doesn't take effect under these condition. - Changes against v4: Update with the test result to measure the potential regression. And rebase this patchset on 5.6.0-rc4. - Changes against v3: Fix the possible risk pointed by Johannes in another patchset [1]. Per discussion with Johannes in that mail thread, I found that the issue Johannes is trying to fix is different with the issue I'm trying to fix. That's why I update this patchset and post it again. This specific memcg protection issue should be addressed. - Changes against v2: 1. Seperates memcg patches from this patchset, suggested by Roman. 2. Improves code around the usage of for_each_mem_cgroup(), suggested by Dave 3. Use memcg_low_reclaim passed from scan_control, instead of introducing a new member in struct mem_cgroup. 4. Some other code improvement suggested by Dave. - Changes against v1: Use the memcg passed from the shrink_control, instead of getting it from inode itself, suggested by Dave. That could make the laying better. [1]. https://lore.kernel.org/linux-mm/20200211175507.178100-1-hannes@cmpxchg.org/ Yafang Shao (3): mm, list_lru: make memcg visible to lru walker isolation function mm, shrinker: make memcg low reclaim visible to lru walker isolation function inode: protect page cache from freeing inode fs/inode.c | 76 ++++++++++++++++++++++++++++++++++++-- include/linux/memcontrol.h | 21 +++++++++++ include/linux/shrinker.h | 3 ++ mm/list_lru.c | 47 +++++++++++++---------- mm/memcontrol.c | 15 -------- mm/vmscan.c | 27 ++++++++------ 6 files changed, 141 insertions(+), 48 deletions(-)