| Message ID | 20201008062620.2928326-1-krisman@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Clean up and fix error handling in DIO | expand |
On Thu 08-10-20 02:26:17, Gabriel Krisman Bertazi wrote: > Hi, > > Given the proximity of the merge window and since I haven't seen it pop > up in any of the trees, and considering it is reviewed and fixes a bug > for us, I'm trying another resend for this so it can get picked up in > time for 5.10. > > Jan, thanks again for the review and sorry for the noise but is there > any one else that should be looking at this? If you can't catch attention of Al Viro, then Jens Axboe is sometimes merging direct IO fixes as well through his tree. Added to CC. If that doesn't work out, I can also take the changes through my tree and send them to Linus in a separate pull request... Honza > Original cover letter: > > This is v3 of Unaligned DIO read error path fix and clean ups. This > version applies some small fixes to patch 1 suggested by Jan Kara (thank > you!) and it was tested with xfstests aio group over f2fs and fio > workloads. > > Archive: > v1: https://lkml.org/lkml/2020/9/14/915 > v2: https://www.spinics.net/lists/linux-fsdevel/msg177220.html > v3: https://www.spinics.net/lists/linux-fsdevel/msg177310.html > > Gabriel Krisman Bertazi (3): > direct-io: clean up error paths of do_blockdev_direct_IO > direct-io: don't force writeback for reads beyond EOF > direct-io: defer alignment check until after the EOF check > > fs/direct-io.c | 69 ++++++++++++++++++++++---------------------------- > 1 file changed, 30 insertions(+), 39 deletions(-) > > -- > 2.28.0 >
On 10/8/20 3:32 AM, Jan Kara wrote: > On Thu 08-10-20 02:26:17, Gabriel Krisman Bertazi wrote: >> Hi, >> >> Given the proximity of the merge window and since I haven't seen it pop >> up in any of the trees, and considering it is reviewed and fixes a bug >> for us, I'm trying another resend for this so it can get picked up in >> time for 5.10. >> >> Jan, thanks again for the review and sorry for the noise but is there >> any one else that should be looking at this? > > If you can't catch attention of Al Viro, then Jens Axboe is sometimes > merging direct IO fixes as well through his tree. Added to CC. If that > doesn't work out, I can also take the changes through my tree and send them > to Linus in a separate pull request... For this case, probably best if you take it, Jan. I looked over the patches and they look good to me, feel free to add: Reviewed-by: Jens Axboe <axboe@kernel.dk>
On Thu 08-10-20 10:16:07, Jens Axboe wrote: > On 10/8/20 3:32 AM, Jan Kara wrote: > > On Thu 08-10-20 02:26:17, Gabriel Krisman Bertazi wrote: > >> Hi, > >> > >> Given the proximity of the merge window and since I haven't seen it pop > >> up in any of the trees, and considering it is reviewed and fixes a bug > >> for us, I'm trying another resend for this so it can get picked up in > >> time for 5.10. > >> > >> Jan, thanks again for the review and sorry for the noise but is there > >> any one else that should be looking at this? > > > > If you can't catch attention of Al Viro, then Jens Axboe is sometimes > > merging direct IO fixes as well through his tree. Added to CC. If that > > doesn't work out, I can also take the changes through my tree and send them > > to Linus in a separate pull request... > > For this case, probably best if you take it, Jan. I looked over the > patches and they look good to me, feel free to add: > > Reviewed-by: Jens Axboe <axboe@kernel.dk> Ok, I'll pull them into my tree. Thanks for review Jens! Honza