[0/2] Better fanotify support for tmpfs

Message

Amir Goldstein March 22, 2021, 5:39 p.m. UTC

Jan,

I needed the tmpfs patch for the userns filesystem mark POC, but it
looks useful for its own right to be able to set filesystem mount or
inode marks on tmpfs with FAN_REPORT_FID.

I can break the cleanup patch into helper and individual patches
for the fs maintainers, but since its so dummy, I thought it might
be best to get an ACK from fs maintainers and carry this as a single
patch.

Thanks,
Amir.

Amir Goldstein (2):
  fs: introduce a wrapper uuid_to_fsid()
  shmem: allow reporting fanotify events with file handles on tmpfs

 fs/ext2/super.c        | 5 +----
 fs/ext4/super.c        | 5 +----
 fs/zonefs/super.c      | 5 +----
 include/linux/statfs.h | 7 +++++++
 mm/shmem.c             | 3 +++
 5 files changed, 13 insertions(+), 12 deletions(-)

Comments

Jan Kara March 23, 2021, 1:25 p.m. UTC | #1

On Mon 22-03-21 19:39:42, Amir Goldstein wrote:
> Jan,
> 
> I needed the tmpfs patch for the userns filesystem mark POC, but it
> looks useful for its own right to be able to set filesystem mount or
> inode marks on tmpfs with FAN_REPORT_FID.
> 
> I can break the cleanup patch into helper and individual patches
> for the fs maintainers, but since its so dummy, I thought it might
> be best to get an ACK from fs maintainers and carry this as a single
> patch.

The series looks fine to me. I'll wait if I get some feedback from Hugh. If
Hugh doesn't object, I'll take the two patches to my tree.

								Honza

> Amir Goldstein (2):
>   fs: introduce a wrapper uuid_to_fsid()
>   shmem: allow reporting fanotify events with file handles on tmpfs
> 
>  fs/ext2/super.c        | 5 +----
>  fs/ext4/super.c        | 5 +----
>  fs/zonefs/super.c      | 5 +----
>  include/linux/statfs.h | 7 +++++++
>  mm/shmem.c             | 3 +++
>  5 files changed, 13 insertions(+), 12 deletions(-)
> 
> -- 
> 2.25.1
>

Christian Brauner March 23, 2021, 2:13 p.m. UTC | #2

On Mon, Mar 22, 2021 at 07:39:42PM +0200, Amir Goldstein wrote:
> Jan,
> 
> I needed the tmpfs patch for the userns filesystem mark POC, but it
> looks useful for its own right to be able to set filesystem mount or
> inode marks on tmpfs with FAN_REPORT_FID.

Indeed.
Seems how to generate the fs_id part based on the uuid is a bit
controversial for some fses (from the xfs thread) but this series seems
useful. Being able to place marks on tmpfs is worth it.

Reviewed-by: Christian Brauner <[e-mail]>