| Message ID | 20211108083840.4627-1-laoar.shao@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | task comm cleanups | expand |
On Mon, Nov 08, 2021 at 08:38:33AM +0000, Yafang Shao wrote: > This patchset is part of the patchset "extend task comm from 16 to 24"[1]. > Now we have different opinion that dynamically allocates memory to store > kthread's long name into a separate pointer, so I decide to take the useful > cleanups apart from the original patchset and send it separately[2]. > > These useful cleanups can make the usage around task comm less > error-prone. Furthermore, it will be useful if we want to extend task > comm in the future. > > All of the patches except patch #4 have either a reviewed-by or a > acked-by now. I have verfied that the vmcore/crash works well after > patch #4. > > [1]. https://lore.kernel.org/lkml/20211101060419.4682-1-laoar.shao@gmail.com/ > [2]. https://lore.kernel.org/lkml/CALOAHbAx55AUo3bm8ZepZSZnw7A08cvKPdPyNTf=E_tPqmw5hw@mail.gmail.com/ Thanks for collecting this! It all looks good to me. Andrew, can you take these? -Kees
This patchset is part of the patchset "extend task comm from 16 to 24"[1]. Now we have different opinion that dynamically allocates memory to store kthread's long name into a separate pointer, so I decide to take the useful cleanups apart from the original patchset and send it separately[2]. These useful cleanups can make the usage around task comm less error-prone. Furthermore, it will be useful if we want to extend task comm in the future. All of the patches except patch #4 have either a reviewed-by or a acked-by now. I have verfied that the vmcore/crash works well after patch #4. [1]. https://lore.kernel.org/lkml/20211101060419.4682-1-laoar.shao@gmail.com/ [2]. https://lore.kernel.org/lkml/CALOAHbAx55AUo3bm8ZepZSZnw7A08cvKPdPyNTf=E_tPqmw5hw@mail.gmail.com/ Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com> Cc: Michal Miroslaw <mirq-linux@rere.qmqm.pl> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Matthew Wilcox <willy@infradead.org> Cc: David Hildenbrand <david@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Kees Cook <keescook@chromium.org> Cc: Petr Mladek <pmladek@suse.com> Yafang Shao (7): fs/exec: make __set_task_comm always set a nul terminated string fs/exec: make __get_task_comm always get a nul terminated string drivers/infiniband: use get_task_comm instead of open-coded string copy fs/binfmt_elf: use get_task_comm instead of open-coded string copy samples/bpf/test_overhead_kprobe_kern: make it adopt to task comm size change tools/bpf/bpftool/skeleton: use bpf_probe_read_kernel_str to get task comm tools/testing/selftests/bpf: make it adopt to task comm size change drivers/infiniband/hw/qib/qib.h | 2 +- drivers/infiniband/hw/qib/qib_file_ops.c | 2 +- fs/binfmt_elf.c | 2 +- fs/exec.c | 5 +++-- include/linux/sched.h | 9 +++++++-- samples/bpf/offwaketime_kern.c | 4 ++-- samples/bpf/test_overhead_kprobe_kern.c | 11 ++++++----- samples/bpf/test_overhead_tp_kern.c | 5 +++-- tools/bpf/bpftool/skeleton/pid_iter.bpf.c | 4 ++-- .../testing/selftests/bpf/progs/test_stacktrace_map.c | 6 +++--- tools/testing/selftests/bpf/progs/test_tracepoint.c | 6 +++--- 11 files changed, 32 insertions(+), 24 deletions(-)