| Message ID | 20220615055755.197-1-xieyongji@bytedance.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Allow skipping abort interface for virtiofs | expand |
On Wed, 15 Jun 2022 at 07:58, Xie Yongji <xieyongji@bytedance.com> wrote: > > The commit 15c8e72e88e0 ("fuse: allow skipping control > interface and forced unmount") tries to remove the control > interface for virtio-fs since it does not support aborting > requests which are being processed. But it doesn't work now. > > This series fixes the bug, but only remove the abort interface > instead since other interfaces should be useful. I'd prefer properly wiring up the fc->no_control if there's no concrete use case for the rest of knobs. Thanks, Miklos
On Mon, Jul 11, 2022 at 4:05 PM Miklos Szeredi <miklos@szeredi.hu> wrote: > > On Wed, 15 Jun 2022 at 07:58, Xie Yongji <xieyongji@bytedance.com> wrote: > > > > The commit 15c8e72e88e0 ("fuse: allow skipping control > > interface and forced unmount") tries to remove the control > > interface for virtio-fs since it does not support aborting > > requests which are being processed. But it doesn't work now. > > > > This series fixes the bug, but only remove the abort interface > > instead since other interfaces should be useful. > > I'd prefer properly wiring up the fc->no_control if there's no > concrete use case for the rest of knobs. > I'm not sure if there are any tools that depend on it. But I didn't find one. So I can try to remove them if we want. Thanks, Yongji
The commit 15c8e72e88e0 ("fuse: allow skipping control interface and forced unmount") tries to remove the control interface for virtio-fs since it does not support aborting requests which are being processed. But it doesn't work now. This series fixes the bug, but only remove the abort interface instead since other interfaces should be useful. V1 to V2: - Split the patch into two part [Vivek] Xie Yongji (2): fuse: Remove unused "no_control" related code virtiofs: allow skipping abort interface fs/fuse/control.c | 4 ++-- fs/fuse/fuse_i.h | 6 +++--- fs/fuse/inode.c | 2 +- fs/fuse/virtio_fs.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-)