[v2,0/5] exfat: Fixes for ENAMETOOLONG error handling

Message

Takashi Iwai July 26, 2022, 8:39 a.m. UTC

Hi,

this is a revised series for fixing the error code of rename syscall
as well as cleanup / suppress the superfluous error messages.

As an LTP test case reported, exfat returns the inconsistent error
code for the case of renaming oversized file names:
  https://bugzilla.suse.com/show_bug.cgi?id=1201725
The first patch fixes this inconsistency.

The second patch is just for correcting the definitions as bit flags,
and the remaining two patches are for suppressing the error message
that can be triggered too easily to debug messages.


thanks,

Takashi

===

v1: https://lore.kernel.org/r/[e-mail]

v1->v2:
* Expand to pr_*() directly in exfat_*() macros
* Add a patch to drop superfluous newlines in error messages

===

Takashi Iwai (5):
  exfat: Return ENAMETOOLONG consistently for oversized paths
  exfat: Define NLS_NAME_* as bit flags explicitly
  exfat: Expand exfat_err() and co directly to pr_*() macro
  exfat: Downgrade ENAMETOOLONG error message to debug messages
  exfat: Drop superfluous new line for error messages

 fs/exfat/exfat_fs.h | 18 ++++++++++--------
 fs/exfat/fatent.c   |  2 +-
 fs/exfat/misc.c     | 17 -----------------
 fs/exfat/namei.c    |  2 +-
 fs/exfat/nls.c      |  4 ++--
 fs/exfat/super.c    |  4 ++--
 6 files changed, 16 insertions(+), 31 deletions(-)

Comments

Namjae Jeon July 29, 2022, 3:08 a.m. UTC | #1

2022-07-26 17:39 GMT+09:00, Takashi Iwai <[e-mail]>:
> Hi,
>
> this is a revised series for fixing the error code of rename syscall
> as well as cleanup / suppress the superfluous error messages.
>
> As an LTP test case reported, exfat returns the inconsistent error
> code for the case of renaming oversized file names:
>   https://bugzilla.suse.com/show_bug.cgi?id=1201725
> The first patch fixes this inconsistency.
>
> The second patch is just for correcting the definitions as bit flags,
> and the remaining two patches are for suppressing the error message
> that can be triggered too easily to debug messages.
Applied, Thanks for your work!
>
>
> thanks,
>
> Takashi
>
> ===
>
> v1: https://lore.kernel.org/r/[e-mail]
>
> v1->v2:
> * Expand to pr_*() directly in exfat_*() macros
> * Add a patch to drop superfluous newlines in error messages
>
> ===
>
> Takashi Iwai (5):
>   exfat: Return ENAMETOOLONG consistently for oversized paths
>   exfat: Define NLS_NAME_* as bit flags explicitly
>   exfat: Expand exfat_err() and co directly to pr_*() macro
>   exfat: Downgrade ENAMETOOLONG error message to debug messages
>   exfat: Drop superfluous new line for error messages
>
>  fs/exfat/exfat_fs.h | 18 ++++++++++--------
>  fs/exfat/fatent.c   |  2 +-
>  fs/exfat/misc.c     | 17 -----------------
>  fs/exfat/namei.c    |  2 +-
>  fs/exfat/nls.c      |  4 ++--
>  fs/exfat/super.c    |  4 ++--
>  6 files changed, 16 insertions(+), 31 deletions(-)
>
> --
> 2.35.3
>
>