mbox series

[PATCHSET,for-next,0/2] Flag file systems as supporting parallel dio writes

Message ID 20230307172015.54911-1-axboe@kernel.dk (mailing list archive)
Headers show
Series Flag file systems as supporting parallel dio writes | expand

Message

Jens Axboe March 7, 2023, 5:20 p.m. UTC 
Hi,

This has been on my TODO list for a while, and now that ext4 supports
parallel dio writes as well, time to dust it off and send it out... This
adds an FMODE flag to inform users that a given file supports parallel
dio writes. io_uring can use this to avoid serializing dio writes
upfront, in case it isn't needed. A few details in patch #2, patch 1 does
nothing by itself.

Comments

Jens Axboe March 15, 2023, 5:40 p.m. UTC | #1 
On 3/7/23 10:20 AM, Jens Axboe wrote:
> Hi,
> 
> This has been on my TODO list for a while, and now that ext4 supports
> parallel dio writes as well, time to dust it off and send it out... This
> adds an FMODE flag to inform users that a given file supports parallel
> dio writes. io_uring can use this to avoid serializing dio writes
> upfront, in case it isn't needed. A few details in patch #2, patch 1 does
> nothing by itself.

I'm assuming silence is consent here and folks are fine with this
change?
Darrick J. Wong March 16, 2023, 4:29 a.m. UTC | #2 
On Wed, Mar 15, 2023 at 11:40:02AM -0600, Jens Axboe wrote:
> On 3/7/23 10:20 AM, Jens Axboe wrote:
> > Hi,
> > 
> > This has been on my TODO list for a while, and now that ext4 supports
> > parallel dio writes as well, time to dust it off and send it out... This
> > adds an FMODE flag to inform users that a given file supports parallel
> > dio writes. io_uring can use this to avoid serializing dio writes
> > upfront, in case it isn't needed. A few details in patch #2, patch 1 does
> > nothing by itself.
> 
> I'm assuming silence is consent here and folks are fine with this
> change?

Oh, yeah, this one fell off my radar.

LGTM,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> -- 
> Jens Axboe
> 
>
Jens Axboe March 17, 2023, 2:53 a.m. UTC | #3 
On 3/15/23 10:29 PM, Darrick J. Wong wrote:
> On Wed, Mar 15, 2023 at 11:40:02AM -0600, Jens Axboe wrote:
>> On 3/7/23 10:20 AM, Jens Axboe wrote:
>>> Hi,
>>>
>>> This has been on my TODO list for a while, and now that ext4 supports
>>> parallel dio writes as well, time to dust it off and send it out... This
>>> adds an FMODE flag to inform users that a given file supports parallel
>>> dio writes. io_uring can use this to avoid serializing dio writes
>>> upfront, in case it isn't needed. A few details in patch #2, patch 1 does
>>> nothing by itself.
>>
>> I'm assuming silence is consent here and folks are fine with this
>> change?
> 
> Oh, yeah, this one fell off my radar.
> 
> LGTM,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks Darrick.
Christian Brauner April 3, 2023, 12:24 p.m. UTC | #4 
On Tue, Mar 07, 2023 at 10:20:13AM -0700, Jens Axboe wrote:
> Hi,
> 
> This has been on my TODO list for a while, and now that ext4 supports
> parallel dio writes as well, time to dust it off and send it out... This
> adds an FMODE flag to inform users that a given file supports parallel
> dio writes. io_uring can use this to avoid serializing dio writes
> upfront, in case it isn't needed. A few details in patch #2, patch 1 does
> nothing by itself.

Looks good,
Reviewed-by: Christian Brauner <brauner@kernel.org>