mbox series

[RESEND,0/3] Add support for tmpfs quotas

Message ID 20240126180225.1210841-1-cem@kernel.org (mailing list archive)
Headers show
Series Add support for tmpfs quotas | expand

Message

Carlos Maiolino Jan. 26, 2024, 6:02 p.m. UTC
From: Carlos Maiolino <cem@kernel.org>

Sending again with Jan's correct email address.

This series add suport for quota management on tmpfs filesystems. Support for
quotas in tmpfs has been added to Linux 6.6, so, give enable users to manage it.

This series add 2 new helpers, one named do_quotactl(), which switches between
quotactl() and quotactl_fd(), and the quotactl_handle() helper within quotaio,
which passes quota_handle data to do_quotactl() depending on the filesystem
associated with the mountpoint.

The first patch is just a cleanup.

Carlos Maiolino (3):
  Rename searched_dir->sd_dir to sd_isdir
  Add quotactl_fd() support
  Enable support for tmpfs quotas

 Makefile.am       |  1 +
 mntopt.h          |  1 +
 quotacheck.c      | 12 +++----
 quotaio.c         | 19 +++++++++--
 quotaio.h         |  2 ++
 quotaio_generic.c | 11 +++----
 quotaio_meta.c    |  3 +-
 quotaio_v1.c      | 11 +++----
 quotaio_v2.c      | 11 +++----
 quotaio_xfs.c     | 21 ++++++------
 quotaon.c         |  8 ++---
 quotaon_xfs.c     |  9 +++---
 quotastats.c      |  4 +--
 quotasync.c       |  2 +-
 quotasys.c        | 82 ++++++++++++++++++++++++++++++++++++-----------
 quotasys.h        |  3 ++
 16 files changed, 134 insertions(+), 66 deletions(-)

Comments

Jan Kara Jan. 29, 2024, 11:59 a.m. UTC | #1
Hi Carlos!

On Fri 26-01-24 19:02:08, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> Sending again with Jan's correct email address.
> 
> This series add suport for quota management on tmpfs filesystems. Support for
> quotas in tmpfs has been added to Linux 6.6, so, give enable users to manage it.
> 
> This series add 2 new helpers, one named do_quotactl(), which switches between
> quotactl() and quotactl_fd(), and the quotactl_handle() helper within quotaio,
> which passes quota_handle data to do_quotactl() depending on the filesystem
> associated with the mountpoint.
> 
> The first patch is just a cleanup.

Thanks for the patches! I did a few small tweaks (e.g. renamed
tmpfs_fstype() to nodev_fstype(), included nfs_fstype() in that function
and used it where appropriate; fixed up compilation breakage with RPC
configured on quotastats) and merged everything. Thanks again.

								Honza

> Carlos Maiolino (3):
>   Rename searched_dir->sd_dir to sd_isdir
>   Add quotactl_fd() support
>   Enable support for tmpfs quotas
> 
>  Makefile.am       |  1 +
>  mntopt.h          |  1 +
>  quotacheck.c      | 12 +++----
>  quotaio.c         | 19 +++++++++--
>  quotaio.h         |  2 ++
>  quotaio_generic.c | 11 +++----
>  quotaio_meta.c    |  3 +-
>  quotaio_v1.c      | 11 +++----
>  quotaio_v2.c      | 11 +++----
>  quotaio_xfs.c     | 21 ++++++------
>  quotaon.c         |  8 ++---
>  quotaon_xfs.c     |  9 +++---
>  quotastats.c      |  4 +--
>  quotasync.c       |  2 +-
>  quotasys.c        | 82 ++++++++++++++++++++++++++++++++++++-----------
>  quotasys.h        |  3 ++
>  16 files changed, 134 insertions(+), 66 deletions(-)
> 
> -- 
> 2.43.0
>
Carlos Maiolino Feb. 5, 2024, 11:48 a.m. UTC | #2
On Mon, Jan 29, 2024 at 12:59:49PM +0100, Jan Kara wrote:
> Hi Carlos!
> 
> On Fri 26-01-24 19:02:08, cem@kernel.org wrote:
> > From: Carlos Maiolino <cem@kernel.org>
> >
> > Sending again with Jan's correct email address.
> >
> > This series add suport for quota management on tmpfs filesystems. Support for
> > quotas in tmpfs has been added to Linux 6.6, so, give enable users to manage it.
> >
> > This series add 2 new helpers, one named do_quotactl(), which switches between
> > quotactl() and quotactl_fd(), and the quotactl_handle() helper within quotaio,
> > which passes quota_handle data to do_quotactl() depending on the filesystem
> > associated with the mountpoint.
> >
> > The first patch is just a cleanup.
> 
> Thanks for the patches! I did a few small tweaks (e.g. renamed
> tmpfs_fstype() to nodev_fstype(), included nfs_fstype() in that function
> and used it where appropriate; fixed up compilation breakage with RPC
> configured on quotastats) and merged everything. Thanks again.

Thanks Honza, much appreciated. I didn't test different configurations, I'll try
that next time I deal with quota-tools.
Thanks again!

Carlos
> 
> 								Honza
> 
> > Carlos Maiolino (3):
> >   Rename searched_dir->sd_dir to sd_isdir
> >   Add quotactl_fd() support
> >   Enable support for tmpfs quotas
> >
> >  Makefile.am       |  1 +
> >  mntopt.h          |  1 +
> >  quotacheck.c      | 12 +++----
> >  quotaio.c         | 19 +++++++++--
> >  quotaio.h         |  2 ++
> >  quotaio_generic.c | 11 +++----
> >  quotaio_meta.c    |  3 +-
> >  quotaio_v1.c      | 11 +++----
> >  quotaio_v2.c      | 11 +++----
> >  quotaio_xfs.c     | 21 ++++++------
> >  quotaon.c         |  8 ++---
> >  quotaon_xfs.c     |  9 +++---
> >  quotastats.c      |  4 +--
> >  quotasync.c       |  2 +-
> >  quotasys.c        | 82 ++++++++++++++++++++++++++++++++++++-----------
> >  quotasys.h        |  3 ++
> >  16 files changed, 134 insertions(+), 66 deletions(-)
> >
> > --
> > 2.43.0
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
>