mbox series

[0/1] fuse: Add initial support for fs-verity

Message ID 20240328205822.1007338-1-richardfung@google.com (mailing list archive)
Headers show
Series fuse: Add initial support for fs-verity | expand

Message

Richard Fung March 28, 2024, 8:58 p.m. UTC
Hi! I am trying to add fs-verity support for virtiofs.

The main complication is that fs-verity ioctls do not have constant
iovec lengths, so simply using _IOC_SIZE like with other ioctls does not
work.

Note this doesn't include support for FS_IOC_READ_VERITY_METADATA.  I
don't know of an existing use of it and I figured it would be better
not to include code that wouldn't be used and tested. However if you feel
like it should be added let me know.

(Also, apologies for any mistakes as this is my first Linux patch!)

Richard Fung (1):
  fuse: Add initial support for fs-verity

 fs/fuse/ioctl.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

Comments

Eric Biggers April 9, 2024, 11:52 p.m. UTC | #1
On Thu, Mar 28, 2024 at 08:58:21PM +0000, Richard Fung wrote:
> Hi! I am trying to add fs-verity support for virtiofs.
> 
> The main complication is that fs-verity ioctls do not have constant
> iovec lengths, so simply using _IOC_SIZE like with other ioctls does not
> work.
> 
> Note this doesn't include support for FS_IOC_READ_VERITY_METADATA.  I
> don't know of an existing use of it and I figured it would be better
> not to include code that wouldn't be used and tested. However if you feel
> like it should be added let me know.
> 
> (Also, apologies for any mistakes as this is my first Linux patch!)
> 
> Richard Fung (1):
>   fuse: Add initial support for fs-verity
> 
>  fs/fuse/ioctl.c | 52 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)

Just a process note: single patches should not use a cover letter.  The
information should be in the patch instead, preferably in the actual commit
message but it's also possible to put text below the scissors line of the patch.

- Eric