[00/30] Remove PG_error flag

Message

Matthew Wilcox April 20, 2024, 2:49 a.m. UTC

We've been steadily reducing the number of places which rely on
PG_error.  There are only two left, so the first five patches remove
those dependencies.

Every patch after the jfs patch is independent, and can be taken by the
respective maintainer immediately.  They might depend on patches I sent
in the last week or two (eg jfs, ntfs3).

Obviously I've done no testing beyond compilation.  All patches can
be found on linux-fsdevel.  I've bcc'd this cover letter to all the
maintainers, and cc'd each patch to whoever's listed in the MAINTAINERS
file.

Matthew Wilcox (Oracle) (30):
  btrfs: Use a folio in wait_dev_supers()
  btrfs: Use a folio in write_dev_supers()
  btrfs: Use the folio iterator in btrfs_end_super_write()
  btrfs: Remove use of the folio error flag
  jfs: Remove use of folio error flag
  bcachefs: Remove calls to folio_set_error
  befs: Convert befs_symlink_read_folio() to use folio_end_read()
  coda: Convert coda_symlink_filler() to use folio_end_read()
  ext2: Remove call to folio_set_error()
  ext4: Remove calls to to set/clear the folio error flag
  fuse: Convert fuse_readpages_end() to use folio_end_read()
  hostfs: Convert hostfs_read_folio() to use a folio
  isofs: Remove calls to set/clear the error flag
  jffs2: Remove calls to set/clear the folio error flag
  nfs: Remove calls to folio_set_error
  nilfs2: Remove calls to folio_set_error() and folio_clear_error()
  ntfs3: Remove calls to set/clear the error flag
  orangefs: Remove calls to set/clear the error flag
  reiserfs: Remove call to folio_set_error()
  romfs: Convert romfs_read_folio() to use a folio
  smb: Remove calls to set folio error flag
  squashfs: Convert squashfs_symlink_read_folio to use folio APIs
  squashfs: Remove calls to set the folio error flag
  ufs: Remove call to set the folio error flag
  vboxsf: Convert vboxsf_read_folio() to use a folio
  mm/memory-failure: Stop setting the folio error flag
  iomap: Remove calls to set and clear folio error flag
  buffer: Remove calls to set and clear the folio error flag
  fs: Remove calls to set and clear the folio error flag
  mm: Remove PG_error

 Documentation/filesystems/vfs.rst      |  3 +-
 fs/bcachefs/fs-io-buffered.c           | 12 +---
 fs/befs/linuxvfs.c                     | 10 ++-
 fs/btrfs/disk-io.c                     | 84 +++++++++++---------------
 fs/btrfs/extent_io.c                   |  2 +-
 fs/btrfs/volumes.h                     |  5 ++
 fs/buffer.c                            |  7 +--
 fs/coda/symlink.c                      | 10 +--
 fs/ext2/dir.c                          |  1 -
 fs/ext4/move_extent.c                  |  4 +-
 fs/ext4/page-io.c                      |  3 -
 fs/ext4/readpage.c                     |  1 -
 fs/fuse/file.c                         | 10 +--
 fs/hostfs/hostfs_kern.c                | 23 ++-----
 fs/iomap/buffered-io.c                 |  8 ---
 fs/isofs/compress.c                    |  4 --
 fs/jffs2/file.c                        | 14 +----
 fs/jfs/jfs_metapage.c                  | 47 +++++++-------
 fs/mpage.c                             | 13 +---
 fs/nfs/read.c                          |  2 -
 fs/nfs/symlink.c                       | 12 +---
 fs/nfs/write.c                         |  1 -
 fs/nilfs2/dir.c                        |  1 -
 fs/nilfs2/segment.c                    |  8 +--
 fs/ntfs3/frecord.c                     |  4 --
 fs/orangefs/inode.c                    | 13 +---
 fs/orangefs/orangefs-bufmap.c          |  4 +-
 fs/proc/page.c                         |  1 -
 fs/reiserfs/inode.c                    |  1 -
 fs/romfs/super.c                       | 22 ++-----
 fs/smb/client/file.c                   |  2 -
 fs/squashfs/file.c                     |  6 +-
 fs/squashfs/file_direct.c              |  3 +-
 fs/squashfs/symlink.c                  | 35 +++++------
 fs/ufs/dir.c                           |  1 -
 fs/vboxsf/file.c                       | 18 ++----
 include/linux/page-flags.h             |  6 +-
 include/trace/events/mmflags.h         |  1 -
 include/uapi/linux/kernel-page-flags.h |  2 +-
 mm/filemap.c                           |  8 ---
 mm/memory-failure.c                    | 29 ---------
 mm/migrate.c                           |  2 -
 42 files changed, 129 insertions(+), 314 deletions(-)

Comments

Theodore Ts'o May 9, 2024, 4:26 a.m. UTC | #1

On Sat, 20 Apr 2024 03:49:55 +0100, Matthew Wilcox (Oracle) wrote:
> We've been steadily reducing the number of places which rely on
> PG_error.  There are only two left, so the first five patches remove
> those dependencies.
> 
> Every patch after the jfs patch is independent, and can be taken by the
> respective maintainer immediately.  They might depend on patches I sent
> in the last week or two (eg jfs, ntfs3).
> 
> [...]

Applied, thanks!

[10/30] ext4: Remove calls to to set/clear the folio error flag
        commit: ea4fd933ab4310822e244af28d22ff63785dea0e

Best regards,