mbox series

[00/16] Prepare to remove PG_error

Message ID 20240530202110.2653630-1-willy@infradead.org (mailing list archive)
Headers show
Series Prepare to remove PG_error | expand

Message

Matthew Wilcox May 30, 2024, 8:20 p.m. UTC
These patches remove almost all remaining uses of PG_error from
filesystems and filesystem helper libraries.  In Linus' tree right now,
there is one place which tests the PG_error bit, and that is removed in
the jfs-next tree.  Thus, it is safe to remove all places which set or
clear the PG_error bit since it is not tested.

The ntfs3 patches are allegedly in progress:
https://lore.kernel.org/linux-fsdevel/85317479-4f03-4896-a2e1-d16b912e8b91@paragon-software.com/
so I haven't included a patch here for them.  We also need to remove one
spot in memory-failure that still sets it, so I haven't gone as far as
deleting PG_error yet.  I guess that's for next merge window.

Matthew Wilcox (Oracle) (16):
  befs: Convert befs_symlink_read_folio() to use folio_end_read()
  coda: Convert coda_symlink_filler() to use folio_end_read()
  cramfs: Convert cramfs_read_folio to use a folio
  efs: Convert efs_symlink_read_folio to use a folio
  hpfs: Convert hpfs_symlink_read_folio to use a folio
  isofs: Convert rock_ridge_symlink_read_folio to use a folio
  hostfs: Convert hostfs_read_folio() to use a folio
  jffs2: Remove calls to set/clear the folio error flag
  nfs: Remove calls to folio_set_error
  orangefs: Remove calls to set/clear the error flag
  reiserfs: Remove call to folio_set_error()
  romfs: Convert romfs_read_folio() to use a folio
  ufs: Remove call to set the folio error flag
  vboxsf: Convert vboxsf_read_folio() to use a folio
  iomap: Remove calls to set and clear folio error flag
  buffer: Remove calls to set and clear the folio error flag

 fs/befs/linuxvfs.c            | 10 ++++------
 fs/buffer.c                   |  7 +------
 fs/coda/symlink.c             | 10 +---------
 fs/cramfs/inode.c             | 25 ++++++++++---------------
 fs/efs/symlink.c              | 14 +++++---------
 fs/hostfs/hostfs_kern.c       | 23 ++++++-----------------
 fs/hpfs/namei.c               | 15 +++------------
 fs/iomap/buffered-io.c        |  8 --------
 fs/isofs/rock.c               | 17 ++++++++---------
 fs/jffs2/file.c               | 14 +++-----------
 fs/mpage.c                    | 13 +++----------
 fs/nfs/read.c                 |  2 --
 fs/nfs/symlink.c              | 12 ++----------
 fs/nfs/write.c                |  1 -
 fs/orangefs/inode.c           | 13 +++----------
 fs/orangefs/orangefs-bufmap.c |  4 +---
 fs/reiserfs/inode.c           |  1 -
 fs/romfs/super.c              | 22 ++++++----------------
 fs/ufs/dir.c                  |  1 -
 fs/vboxsf/file.c              | 18 +++++-------------
 20 files changed, 61 insertions(+), 169 deletions(-)

Comments

Christian Brauner May 31, 2024, 10:34 a.m. UTC | #1
On Thu, 30 May 2024 21:20:52 +0100, Matthew Wilcox (Oracle) wrote:
> These patches remove almost all remaining uses of PG_error from
> filesystems and filesystem helper libraries.  In Linus' tree right now,
> there is one place which tests the PG_error bit, and that is removed in
> the jfs-next tree.  Thus, it is safe to remove all places which set or
> clear the PG_error bit since it is not tested.
> 
> The ntfs3 patches are allegedly in progress:
> https://lore.kernel.org/linux-fsdevel/85317479-4f03-4896-a2e1-d16b912e8b91@paragon-software.com/
> so I haven't included a patch here for them.  We also need to remove one
> spot in memory-failure that still sets it, so I haven't gone as far as
> deleting PG_error yet.  I guess that's for next merge window.
> 
> [...]

Nice cleanup!

---

Applied to the vfs.pg_error branch of the vfs/vfs.git tree.
Patches in the vfs.pg_error branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.pg_error

[01/16] befs: Convert befs_symlink_read_folio() to use folio_end_read()
        https://git.kernel.org/vfs/vfs/c/263cf5780497
[02/16] coda: Convert coda_symlink_filler() to use folio_end_read()
        https://git.kernel.org/vfs/vfs/c/8c30a7344abe
[03/16] cramfs: Convert cramfs_read_folio to use a folio
        https://git.kernel.org/vfs/vfs/c/def27a205420
[04/16] efs: Convert efs_symlink_read_folio to use a folio
        https://git.kernel.org/vfs/vfs/c/09da047e554d
[05/16] hpfs: Convert hpfs_symlink_read_folio to use a folio
        https://git.kernel.org/vfs/vfs/c/4c59e914ef1a
[06/16] isofs: Convert rock_ridge_symlink_read_folio to use a folio
        https://git.kernel.org/vfs/vfs/c/4df37c5f0882
[07/16] hostfs: Convert hostfs_read_folio() to use a folio
        https://git.kernel.org/vfs/vfs/c/e3ec0fe944d2
[08/16] jffs2: Remove calls to set/clear the folio error flag
        https://git.kernel.org/vfs/vfs/c/d15b00b1e588
[09/16] nfs: Remove calls to folio_set_error
        https://git.kernel.org/vfs/vfs/c/8f3ab6e4bebe
[10/16] orangefs: Remove calls to set/clear the error flag
        https://git.kernel.org/vfs/vfs/c/86b3d5f6df0e
[11/16] reiserfs: Remove call to folio_set_error()
        https://git.kernel.org/vfs/vfs/c/f4c51473d22a
[12/16] romfs: Convert romfs_read_folio() to use a folio
        https://git.kernel.org/vfs/vfs/c/d86f2de026c5
[13/16] ufs: Remove call to set the folio error flag
        https://git.kernel.org/vfs/vfs/c/ca7d585639b5
[14/16] vboxsf: Convert vboxsf_read_folio() to use a folio
        https://git.kernel.org/vfs/vfs/c/55050b6873c6
[15/16] iomap: Remove calls to set and clear folio error flag
        https://git.kernel.org/vfs/vfs/c/1f56eedf7ff7
[16/16] buffer: Remove calls to set and clear the folio error flag
        https://git.kernel.org/vfs/vfs/c/7ad635ea8270