| Message ID | 20240627-work-pidfs-v1-0-7e9ab6cc3bb1@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | pidfs: allow retrieval of namespace descriptors | expand |
On Thu, 2024-06-27 at 16:11 +0200, Christian Brauner wrote: > In recent discussions it became clear that having the ability to go > from > pidfd to namespace file descriptor is desirable. Not just because it > is > already possible to use pidfds with setns() to switch namespaces > atomically but also because it makes it possible to interact with > namespaces without having procfs mounted solely relying on the pidfd. > > This adds support from deriving a namespace file descriptor from a > pidfd for all namespace types. > > Thanks! > Christian > > --- > --- > base-commit: 2a79498f76350570427af72da04b1c7d0e24149e > change-id: 20240627-work-pidfs-fd415f4d3cd1 > Neat. I'm not too familiar with all of the CLASS() macro stuff so it took me a minute to unwind, but this all looks pretty straightforward. Reviewed-by: Jeff Layton <jlayton@kernel.org>
On Thu, Jun 27, 2024 at 04:11:38PM +0200, Christian Brauner wrote: > In recent discussions it became clear that having the ability to go from > pidfd to namespace file descriptor is desirable. Not just because it is > already possible to use pidfds with setns() to switch namespaces > atomically but also because it makes it possible to interact with > namespaces without having procfs mounted solely relying on the pidfd. > > This adds support from deriving a namespace file descriptor from a > pidfd for all namespace types. > I love this, just have the one comment about documenting how the take_fd() thing works, but then you can add Reviewed-by: Josef Bacik <josef@toxicpanda.com> Thanks, Josef
Am Do., 27. Juni 2024 um 16:11 Uhr schrieb Christian Brauner <brauner@kernel.org>: > > In recent discussions it became clear that having the ability to go from > pidfd to namespace file descriptor is desirable. Not just because it is > already possible to use pidfds with setns() to switch namespaces > atomically but also because it makes it possible to interact with > namespaces without having procfs mounted solely relying on the pidfd. > > This adds support from deriving a namespace file descriptor from a > pidfd for all namespace types. Extremely useful API. Thanks! Reviewed-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com> > > Thanks! > Christian > > --- > --- > base-commit: 2a79498f76350570427af72da04b1c7d0e24149e > change-id: 20240627-work-pidfs-fd415f4d3cd1 >