[PATCHv2,fs/bfs,0/2] bfs: fix null-ptr-deref and possible warning in bfs_move_block() func

Message

Vasiliy Kovalev July 11, 2024, 7:32 a.m. UTC

https://syzkaller.appspot.com/bug?extid=d98fd19acd08b36ff422

[PATCHv2 fs/bfs 1/2] bfs: prevent null pointer dereference in bfs_move_block()
---
v2: corrected the commit message and explicitly initialized
the return variable with zero (Markus Elfring)
---
[PATCHv2 fs/bfs 2/2] bfs: add buffer_uptodate check before mark_buffer_dirty
---
v2: renamed the return variable  err -> ret (Markus Elfring)
---

Comments

Markus Elfring July 11, 2024, 7:47 a.m. UTC | #1

…
> [PATCHv2 fs/bfs 1/2] bfs: prevent null pointer dereference in bfs_move_block()
…

I find it usually helpful to separate the version identifier from the previous key word.

How do you think about to improve the outline another bit (also for the cover letter)?

Regards,
Markus

Vasiliy Kovalev July 11, 2024, 8:13 a.m. UTC | #2

11.07.2024 10:47, Markus Elfring wrote:
> …
>> [PATCHv2 fs/bfs 1/2] bfs: prevent null pointer dereference in bfs_move_block()
> …
> 
> I find it usually helpful to separate the version identifier from the previous key word.
> 
> How do you think about to improve the outline another bit (also for the cover letter)?

I will take your recommendation into account when submitting the next 
versions, if there are any comments on the patches themselves.

> Regards,
> Markus