| Message ID | 20240717154716.237943-1-willy@infradead.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Convert write_begin / write_end to take a folio | expand |
On Wed, Jul 17, 2024 at 04:46:50PM +0100, Matthew Wilcox (Oracle) wrote: > You can find the full branch at > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end > aka > git://git.infradead.org/users/willy/pagecache.git write-end > > On top of the ufs, minix, sysv and qnx6 directory handling patches, this > patch series converts us to using folios for write_begin and write_end. > That's the last mention of 'struct page' in several filesystems. > > I'd like to get some version of these patches into the 6.12 merge > window. > > Matthew Wilcox (Oracle) (23): > reiserfs: Convert grab_tail_page() to use a folio > reiserfs: Convert reiserfs_write_begin() to use a folio > block: Use a folio in blkdev_write_end() > buffer: Use a folio in generic_write_end() > nilfs2: Use a folio in nilfs_recover_dsync_blocks() > ntfs3: Remove reset_log_file() > buffer: Convert block_write_end() to take a folio > ecryptfs: Convert ecryptfs_write_end() to use a folio > ecryptfs: Use a folio in ecryptfs_write_begin() > f2fs: Convert f2fs_write_end() to use a folio > f2fs: Convert f2fs_write_begin() to use a folio > fuse: Convert fuse_write_end() to use a folio > fuse: Convert fuse_write_begin() to use a folio > hostfs: Convert hostfs_write_end() to use a folio > jffs2: Convert jffs2_write_end() to use a folio > jffs2: Convert jffs2_write_begin() to use a folio > orangefs: Convert orangefs_write_end() to use a folio > orangefs: Convert orangefs_write_begin() to use a folio > vboxsf: Use a folio in vboxsf_write_end() > fs: Convert aops->write_end to take a folio > fs: Convert aops->write_begin to take a folio > ocfs2: Convert ocfs2_write_zero_page to use a folio > buffer: Convert __block_write_begin() to take a folio I applied and reviewed this, the per-fs stuff obviously I'm less familiar with, I mostly just validated it was 1:1 conversion and that the behavior matched the previous behavior. You can add Reviewed-by: Josef Bacik <josef@toxicpanda.com> to the series. Thanks, Josef
On Wed, Jul 17, 2024 at 04:46:50PM GMT, Matthew Wilcox wrote: > You can find the full branch at > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end > aka > git://git.infradead.org/users/willy/pagecache.git write-end > > On top of the ufs, minix, sysv and qnx6 directory handling patches, this > patch series converts us to using folios for write_begin and write_end. > That's the last mention of 'struct page' in several filesystems. > > I'd like to get some version of these patches into the 6.12 merge > window. Is it stable enough that I can already pull it from you? I'd like this to be based on v6.11-rc1.
On Tue, Jul 23, 2024 at 09:49:10AM +0200, Christian Brauner wrote: > On Wed, Jul 17, 2024 at 04:46:50PM GMT, Matthew Wilcox wrote: > > You can find the full branch at > > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end > > aka > > git://git.infradead.org/users/willy/pagecache.git write-end > > > > On top of the ufs, minix, sysv and qnx6 directory handling patches, this > > patch series converts us to using folios for write_begin and write_end. > > That's the last mention of 'struct page' in several filesystems. > > > > I'd like to get some version of these patches into the 6.12 merge > > window. > > Is it stable enough that I can already pull it from you? > I'd like this to be based on v6.11-rc1. It's stable in that it works, but it's still based on linux-next. I think it probably depends on a few fs git pulls that are still outstanding. More awkwardly for merging is that it depends on the four directory handling patch series, each of which you've put on a separate topic branch. So I'm not sure how you want to handle that.
On Tue, Jul 23, 2024 at 02:20:46PM GMT, Matthew Wilcox wrote: > On Tue, Jul 23, 2024 at 09:49:10AM +0200, Christian Brauner wrote: > > On Wed, Jul 17, 2024 at 04:46:50PM GMT, Matthew Wilcox wrote: > > > You can find the full branch at > > > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end > > > aka > > > git://git.infradead.org/users/willy/pagecache.git write-end > > > > > > On top of the ufs, minix, sysv and qnx6 directory handling patches, this > > > patch series converts us to using folios for write_begin and write_end. > > > That's the last mention of 'struct page' in several filesystems. > > > > > > I'd like to get some version of these patches into the 6.12 merge > > > window. > > > > Is it stable enough that I can already pull it from you? > > I'd like this to be based on v6.11-rc1. > > It's stable in that it works, but it's still based on linux-next. I think > it probably depends on a few fs git pulls that are still outstanding. > More awkwardly for merging is that it depends on the four directory > handling patch series, each of which you've put on a separate topic > branch. So I'm not sure how you want to handle that. I've put them there before this series here surfaced. But anyway, there's plenty of options. I can merge all separate topic branches together in a main branch or I can just pull it all in together. That depends how complex it turns out to be.
On Tue, Jul 23, 2024 at 03:41:37PM +0200, Christian Brauner wrote: > On Tue, Jul 23, 2024 at 02:20:46PM GMT, Matthew Wilcox wrote: > > On Tue, Jul 23, 2024 at 09:49:10AM +0200, Christian Brauner wrote: > > > On Wed, Jul 17, 2024 at 04:46:50PM GMT, Matthew Wilcox wrote: > > > > You can find the full branch at > > > > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end > > > > aka > > > > git://git.infradead.org/users/willy/pagecache.git write-end > > > > > > > > On top of the ufs, minix, sysv and qnx6 directory handling patches, this > > > > patch series converts us to using folios for write_begin and write_end. > > > > That's the last mention of 'struct page' in several filesystems. > > > > > > > > I'd like to get some version of these patches into the 6.12 merge > > > > window. > > > > > > Is it stable enough that I can already pull it from you? > > > I'd like this to be based on v6.11-rc1. > > > > It's stable in that it works, but it's still based on linux-next. I think > > it probably depends on a few fs git pulls that are still outstanding. > > More awkwardly for merging is that it depends on the four directory > > handling patch series, each of which you've put on a separate topic > > branch. So I'm not sure how you want to handle that. > > I've put them there before this series here surfaced. But anyway, > there's plenty of options. I can merge all separate topic branches > together in a main branch or I can just pull it all in together. That > depends how complex it turns out to be. I've rebased to current-ish Linus, updated to commit f45c4246ab18 at the above URL. It all seems to work well enough, so I'm not relying on any later commits. I can rebase it onto -rc1 when it is tagged, or you can pull it now if you'd rather. It's missing the R-b/A-b tags from Josef & Ryusuke Konishi.
On Tue, Jul 23, 2024 at 11:54:25PM GMT, Matthew Wilcox wrote: > On Tue, Jul 23, 2024 at 03:41:37PM +0200, Christian Brauner wrote: > > On Tue, Jul 23, 2024 at 02:20:46PM GMT, Matthew Wilcox wrote: > > > On Tue, Jul 23, 2024 at 09:49:10AM +0200, Christian Brauner wrote: > > > > On Wed, Jul 17, 2024 at 04:46:50PM GMT, Matthew Wilcox wrote: > > > > > You can find the full branch at > > > > > http://git.infradead.org/?p=users/willy/pagecache.git;a=shortlog;h=refs/heads/write-end > > > > > aka > > > > > git://git.infradead.org/users/willy/pagecache.git write-end > > > > > > > > > > On top of the ufs, minix, sysv and qnx6 directory handling patches, this > > > > > patch series converts us to using folios for write_begin and write_end. > > > > > That's the last mention of 'struct page' in several filesystems. > > > > > > > > > > I'd like to get some version of these patches into the 6.12 merge > > > > > window. > > > > > > > > Is it stable enough that I can already pull it from you? > > > > I'd like this to be based on v6.11-rc1. > > > > > > It's stable in that it works, but it's still based on linux-next. I think > > > it probably depends on a few fs git pulls that are still outstanding. > > > More awkwardly for merging is that it depends on the four directory > > > handling patch series, each of which you've put on a separate topic > > > branch. So I'm not sure how you want to handle that. > > > > I've put them there before this series here surfaced. But anyway, > > there's plenty of options. I can merge all separate topic branches > > together in a main branch or I can just pull it all in together. That > > depends how complex it turns out to be. > > I've rebased to current-ish Linus, updated to commit f45c4246ab18 at > the above URL. It all seems to work well enough, so I'm not relying on > any later commits. I can rebase it onto -rc1 when it is tagged, or > you can pull it now if you'd rather. It's missing the R-b/A-b tags > from Josef & Ryusuke Konishi. I've rebased to v6.11-rc1 and added the missing Acks. I also added your SoB to "qnx6: Convert directory handling to use kmap_local" which was missing. Let me know if anything looks wrong. It's in the vfs.folio branch.