[0/4] nilfs2: Finish folio conversion

Message

Matthew Wilcox Oct. 2, 2024, 3 p.m. UTC

After "nilfs2: Convert nilfs_copy_buffer() to use folios", there are
only a few remaining users of struct page in all of nilfs2, and they're
straightforward to remove.  Build tested only.

Matthew Wilcox (Oracle) (4):
  nilfs2: Remove nilfs_writepage
  nilfs2: Convert nilfs_page_count_clean_buffers() to take a folio
  nilfs2: Convert nilfs_recovery_copy_block() to take a folio
  nilfs2: Convert metadata aops from writepage to writepages

 fs/nilfs2/dir.c      |  2 +-
 fs/nilfs2/inode.c    | 35 ++---------------------------------
 fs/nilfs2/mdt.c      | 19 +++++++++++++++----
 fs/nilfs2/page.c     |  4 ++--
 fs/nilfs2/page.h     |  4 ++--
 fs/nilfs2/recovery.c | 11 ++++-------
 6 files changed, 26 insertions(+), 49 deletions(-)

Comments

Ryusuke Konishi Oct. 2, 2024, 3:40 p.m. UTC | #1

On Thu, Oct 3, 2024 at 12:00 AM Matthew Wilcox (Oracle) wrote:
>
> After "nilfs2: Convert nilfs_copy_buffer() to use folios", there are
> only a few remaining users of struct page in all of nilfs2, and they're
> straightforward to remove.  Build tested only.

Thank you for your ongoing work on converting to folio-based.

Page structure references still remain in other files, but I'm
preparing a patch set to convert them to be folio-based, so together
with that, I think we'll be able to remove most of the page references
in nilfs2 in the next cycle.

I'll check out this patch set.

Thanks,
Ryusuke Konishi

>
> Matthew Wilcox (Oracle) (4):
>   nilfs2: Remove nilfs_writepage
>   nilfs2: Convert nilfs_page_count_clean_buffers() to take a folio
>   nilfs2: Convert nilfs_recovery_copy_block() to take a folio
>   nilfs2: Convert metadata aops from writepage to writepages
>
>  fs/nilfs2/dir.c      |  2 +-
>  fs/nilfs2/inode.c    | 35 ++---------------------------------
>  fs/nilfs2/mdt.c      | 19 +++++++++++++++----
>  fs/nilfs2/page.c     |  4 ++--
>  fs/nilfs2/page.h     |  4 ++--
>  fs/nilfs2/recovery.c | 11 ++++-------
>  6 files changed, 26 insertions(+), 49 deletions(-)
>
> --
> 2.43.0
>

Ryusuke Konishi Oct. 3, 2024, 12:20 p.m. UTC | #2

On Thu, Oct 3, 2024 at 12:40 AM Ryusuke Konishi wrote:
>
> On Thu, Oct 3, 2024 at 12:00 AM Matthew Wilcox (Oracle) wrote:
> >
> > After "nilfs2: Convert nilfs_copy_buffer() to use folios", there are
> > only a few remaining users of struct page in all of nilfs2, and they're
> > straightforward to remove.  Build tested only.
>
> Thank you for your ongoing work on converting to folio-based.
>
> Page structure references still remain in other files, but I'm
> preparing a patch set to convert them to be folio-based, so together
> with that, I think we'll be able to remove most of the page references
> in nilfs2 in the next cycle.
>
> I'll check out this patch set.
>
> Thanks,
> Ryusuke Konishi

I've added comments to each patch based on my review and testing.

The biggest comment is about the kernel panic caused by patches 1/4
and 4/4.  As I wrote in my reply to each of them, this can be fixed by
replacing "buffer_migrate_folio" with "buffer_migrate_folio_norefs".

If you are busy and don't mind, I can fix the points I commented on.
If so, please let me know.
Or if you send me the v2 patchset, I'll check it again and add it to
the patches I'll send upstream for the next cycle.

Thanks,
Ryusuke Konishi