[v3,0/2] pipe: don't update {a,c,m}time for anonymous pipes

Message

Oleg Nesterov Feb. 5, 2025, 6:17 p.m. UTC

OK, let me send v3 right now...

Changes: make pipeanon_fops static.

Link to v1: https://lore.kernel.org/all/[e-mail]/
Link to v2: https://lore.kernel.org/all/[e-mail]/

Oleg.
---

 fs/pipe.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 47 insertions(+), 15 deletions(-)

Comments

K Prateek Nayak Feb. 6, 2025, 3:12 a.m. UTC | #1

Hello Oleg,

On 2/5/2025 11:47 PM, Oleg Nesterov wrote:
> OK, let me send v3 right now...

Tested this series with sched-messaging on my 3rd Generation EPYC
system (2 x64c/128T, boost on, C2 disabled) and I see slight
improvements:

   ==================================================================
   Test          : sched-messaging
   Units         : Normalized time in seconds
   Interpretation: Lower is better
   Statistic     : AMean
   ==================================================================
   Case:      upstream[pct imp](CV)    skip_{a,c,m}_time[pct imp](CV)
    1-groups     1.00 [ -0.00]( 9.88)     1.05 [ -5.16]( 7.19) *
    2-groups     1.00 [ -0.00]( 3.49)     0.97 [  2.70]( 3.54)
    4-groups     1.00 [ -0.00]( 1.22)     0.97 [  2.70]( 2.78)
    8-groups     1.00 [ -0.00]( 0.80)     0.99 [  0.94]( 1.04)
   16-groups     1.00 [ -0.00]( 1.40)     0.98 [  2.43]( 1.02)
   
   * Disregard these data points due to large run to run variation

Feel free to add:

Tested-by: K Prateek Nayak <[e-mail]>

I'll go test the pipe_{read,write}() cleanup you had posted on the
other thread.

Christian Brauner Feb. 6, 2025, 9:55 a.m. UTC | #2

On Wed, 05 Feb 2025 19:17:16 +0100, Oleg Nesterov wrote:
> OK, let me send v3 right now...
> 
> Changes: make pipeanon_fops static.
> 
> Link to v1: https://lore.kernel.org/all/[e-mail]/
> Link to v2: https://lore.kernel.org/all/[e-mail]/
> 
> [...]

Applied to the vfs-6.15.pipe branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.pipe branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.pipe

[1/2] pipe: introduce struct file_operations pipeanon_fops
      https://git.kernel.org/vfs/vfs/c/262b2fa99cbe
[2/2] pipe: don't update {a,c,m}time for anonymous pipes
      https://git.kernel.org/vfs/vfs/c/f017b0a4951f

Jeff Layton Feb. 6, 2025, 12:33 p.m. UTC | #3

On Wed, 2025-02-05 at 19:17 +0100, Oleg Nesterov wrote:
> OK, let me send v3 right now...
> 
> Changes: make pipeanon_fops static.
> 
> Link to v1: https://lore.kernel.org/all/[e-mail]/
> Link to v2: https://lore.kernel.org/all/[e-mail]/
> 
> Oleg.
> ---
> 
>  fs/pipe.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 47 insertions(+), 15 deletions(-)
> 

Reviewed-by: Jeff Layton <[e-mail]>