[v2,0/9] Orangefs fixes for 6.15

Message

Matthew Wilcox March 5, 2025, 8:47 p.m. UTC

The start of this was the removal of orangefs_writepage(), but it quickly
spiralled into a more comprehensive cleanup.  The first patch is an
actual bug fix.  I haven't tagged it for backport, as I don't think we
really care about 32-bit systems any more, but feel free to add a cc to
stable if you disagree.

Patches 2 and 3 are compilation fixes for warnings which aren't enabled
by default.

Patches 4-9 are improvements which simplify orangefs or convert it
from pages to folios.  There is still a little use of 'struct page'
in orangefs, but it's not in the areas that deal with the page cache.

Matthew Wilcox (Oracle) (9):
  orangefs: Do not truncate file size
  orangefs: Move s_kmod_keyword_mask_map to orangefs-debugfs.c
  orangefs: make open_for_read and open_for_write boolean
  orangefs: Remove orangefs_writepage()
  orangefs: Convert orangefs_writepage_locked() to take a folio
  orangefs: Pass mapping to orangefs_writepages_work()
  orangefs: Unify error & success paths in orangefs_writepages_work()
  orangefs: Simplify bvec setup in orangefs_writepages_work()
  orangefs: Convert orangefs_writepages to contain an array of folios

 fs/orangefs/file.c             |   4 +-
 fs/orangefs/inode.c            | 149 ++++++++++++++-------------------
 fs/orangefs/orangefs-debug.h   |  43 ----------
 fs/orangefs/orangefs-debugfs.c |  43 ++++++++++
 4 files changed, 109 insertions(+), 130 deletions(-)

Comments

Christian Brauner March 6, 2025, 8:26 a.m. UTC | #1

On Wed, 05 Mar 2025 20:47:24 +0000, Matthew Wilcox (Oracle) wrote:
> The start of this was the removal of orangefs_writepage(), but it quickly
> spiralled into a more comprehensive cleanup.  The first patch is an
> actual bug fix.  I haven't tagged it for backport, as I don't think we
> really care about 32-bit systems any more, but feel free to add a cc to
> stable if you disagree.
> 
> Patches 2 and 3 are compilation fixes for warnings which aren't enabled
> by default.
> 
> [...]

Applied to the vfs-6.15.orangefs branch of the vfs/vfs.git tree.
Patches in the vfs-6.15.orangefs branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.15.orangefs

[1/9] orangefs: Do not truncate file size
      https://git.kernel.org/vfs/vfs/c/062e8093592f
[2/9] orangefs: Move s_kmod_keyword_mask_map to orangefs-debugfs.c
      https://git.kernel.org/vfs/vfs/c/50fb0a7f43c0
[3/9] orangefs: make open_for_read and open_for_write boolean
      https://git.kernel.org/vfs/vfs/c/144fa8ae0830
[4/9] orangefs: Remove orangefs_writepage()
      https://git.kernel.org/vfs/vfs/c/506382dbbedc
[5/9] orangefs: Convert orangefs_writepage_locked() to take a folio
      https://git.kernel.org/vfs/vfs/c/40eca026bbaa
[6/9] orangefs: Pass mapping to orangefs_writepages_work()
      https://git.kernel.org/vfs/vfs/c/6420f17963f2
[7/9] orangefs: Unify error & success paths in orangefs_writepages_work()
      https://git.kernel.org/vfs/vfs/c/f9ec21357f52
[8/9] orangefs: Simplify bvec setup in orangefs_writepages_work()
      https://git.kernel.org/vfs/vfs/c/377afd97cf18
[9/9] orangefs: Convert orangefs_writepages to contain an array of folios
      https://git.kernel.org/vfs/vfs/c/73f233b972ce