| Message ID | 20250307182151.3397003-1-willy@infradead.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | f2fs: Remove uses of writepage | expand |
On 03/07, Matthew Wilcox (Oracle) wrote: > I was planning on sending this next cycle, but maybe there's time to > squeeze these patches into the upcoming merge window? > > f2fs already implements writepages and migrate_folio for all three > address_space_operations, so either ->writepage will never be called (by > migration) or it will only be harmful (if called from pageout()). My tree sitting on [1] doesn't have mm-next, which looks difficult to test this series for test alone. Matthew, can you point which patches I need to apply in mm along with this for test? [1] f286757b644c "Merge tag 'timers-urgent-2025-02-03' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip" > > The only remaining filesystem with ->writepage defined in next-20250307 > is vboxsf, so the concept of removing ->writepage is well proven. I > have some follow-up patches which simplify f2fs writeback afterwards, > but I think we can postpone them to next cycle. > > See > https://lore.kernel.org/linux-fsdevel/20250307135414.2987755-1-willy@infradead.org/ > for where we're going; the first four patches in that series are the > same as the four patches in this series, and I've split them out here > for your convenience. > > Matthew Wilcox (Oracle) (4): > f2fs: Remove check for ->writepage > f2fs: Remove f2fs_write_data_page() > f2fs: Remove f2fs_write_meta_page() > f2fs: Remove f2fs_write_node_page() > > fs/f2fs/checkpoint.c | 7 ------- > fs/f2fs/data.c | 28 ---------------------------- > fs/f2fs/node.c | 8 -------- > 3 files changed, 43 deletions(-) > > -- > 2.47.2
On Fri, Mar 07, 2025 at 08:39:56PM +0000, Jaegeuk Kim wrote: > On 03/07, Matthew Wilcox (Oracle) wrote: > > I was planning on sending this next cycle, but maybe there's time to > > squeeze these patches into the upcoming merge window? > > > > f2fs already implements writepages and migrate_folio for all three > > address_space_operations, so either ->writepage will never be called (by > > migration) or it will only be harmful (if called from pageout()). > > My tree sitting on [1] doesn't have mm-next, which looks difficult to test this > series for test alone. Matthew, can you point which patches I need to apply > in mm along with this for test? > > [1] f286757b644c "Merge tag 'timers-urgent-2025-02-03' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip" Oh, you don't need any extra patches. The ->writepage removal has been going on since mid-2021 (commit 21b4ee7029c9 was the first removal, I believe).
On 03/07, Matthew Wilcox wrote: > On Fri, Mar 07, 2025 at 08:39:56PM +0000, Jaegeuk Kim wrote: > > On 03/07, Matthew Wilcox (Oracle) wrote: > > > I was planning on sending this next cycle, but maybe there's time to > > > squeeze these patches into the upcoming merge window? > > > > > > f2fs already implements writepages and migrate_folio for all three > > > address_space_operations, so either ->writepage will never be called (by > > > migration) or it will only be harmful (if called from pageout()). > > > > My tree sitting on [1] doesn't have mm-next, which looks difficult to test this > > series for test alone. Matthew, can you point which patches I need to apply > > in mm along with this for test? > > > > [1] f286757b644c "Merge tag 'timers-urgent-2025-02-03' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip" > > Oh, you don't need any extra patches. The ->writepage removal has been > going on since mid-2021 (commit 21b4ee7029c9 was the first removal, I > believe). Ah, I see. Thank you for the confirmation. Let me apply them and test a quick.
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <jaegeuk@kernel.org>: On Fri, 7 Mar 2025 18:21:46 +0000 you wrote: > I was planning on sending this next cycle, but maybe there's time to > squeeze these patches into the upcoming merge window? > > f2fs already implements writepages and migrate_folio for all three > address_space_operations, so either ->writepage will never be called (by > migration) or it will only be harmful (if called from pageout()). > > [...] Here is the summary with links: - [f2fs-dev,1/4] f2fs: Remove check for ->writepage https://git.kernel.org/jaegeuk/f2fs/c/448a834f89ad - [f2fs-dev,2/4] f2fs: Remove f2fs_write_data_page() https://git.kernel.org/jaegeuk/f2fs/c/6ad3ddbee892 - [f2fs-dev,3/4] f2fs: Remove f2fs_write_meta_page() https://git.kernel.org/jaegeuk/f2fs/c/3b47398d9861 - [f2fs-dev,4/4] f2fs: Remove f2fs_write_node_page() https://git.kernel.org/jaegeuk/f2fs/c/7ff0104a8052 You are awesome, thank you!
On Tue, Mar 11, 2025 at 07:50:38PM +0000, patchwork-bot+f2fs@kernel.org wrote: > Hello: > > This series was applied to jaegeuk/f2fs.git (dev) > by Jaegeuk Kim <jaegeuk@kernel.org>: Thanks! FWIW, I have a tree with 75 patches in it on top of this that do more folio conversion work. It's not done yet; maybe another 200 patches to go? I don't think it's worth posting at this point in the cycle, so I'll wait until -rc1 to post, by which point it'll probably be much larger.
On 03/12, Matthew Wilcox wrote: > On Tue, Mar 11, 2025 at 07:50:38PM +0000, patchwork-bot+f2fs@kernel.org wrote: > > Hello: > > > > This series was applied to jaegeuk/f2fs.git (dev) > > by Jaegeuk Kim <jaegeuk@kernel.org>: > > Thanks! > > FWIW, I have a tree with 75 patches in it on top of this that do more > folio conversion work. It's not done yet; maybe another 200 patches to > go? I don't think it's worth posting at this point in the cycle, so > I'll wait until -rc1 to post, by which point it'll probably be much > larger. Ok, thanks for the work! Will keep an eye on.