| Message ID | 536f13a9-0890-7e69-65e9-5fe1a30e04ef@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fs/ntfs3: Fix and rename hidedotfiles mount option | expand |
Às 09:08 de 09/10/22, Kari Argillander escreveu: > On Fri, 7 Oct 2022 at 15:32, Daniel Pinto <danielpinto52@gmail.com> wrote: >> >> The current implementation of the hidedotfiles has some problems, namely: >> - there is a bug where enabling it actually disables it and vice versa >> - it only works when creating files, not when moving or renaming them >> - is is not listed in the enabled options list by the mount command >> - its name differs from the equivalent hide_dot_files mount option >> used by NTFS-3G, making it incompatible with it for no reason >> >> This series of patches tries to fix those problems. > > While you are fixing this can you also make patch to add documentation > for this mount option. I also think we really should not make new mount > option names so I would vote hide_dot_files name as you did. We still have > time for this change as this is not yet in upstream. > I have submitted a v2 of the patch which includes a commit with the documentation. >> Daniel Pinto (4): >> fs/ntfs3: fix hidedotfiles mount option by reversing behaviour >> fs/ntfs3: make hidedotfiles mount option work when renaming files >> fs/ntfs3: add hidedotfiles to the list of enabled mount options >> fs/ntfs3: rename hidedotfiles mount option to hide_dot_files >> >> fs/ntfs3/frecord.c | 9 +++++++++ >> fs/ntfs3/inode.c | 2 +- >> fs/ntfs3/super.c | 6 ++++-- >> 3 files changed, 14 insertions(+), 3 deletions(-) >> >