[00/11] Bugfix and refactoring

Message

Konstantin Komarov April 17, 2024, 1:03 p.m. UTC

This series contains various fixes and refactoring for ntfs3.
Fixed problem with incorrect link counting for files with DOS names.

Konstantin Komarov (11):
   fs/ntfs3: Remove max link count info display during driver init
   fs/ntfs3: Missed le32_to_cpu conversion
   fs/ntfs3: Mark volume as dirty if xattr is broken
   fs/ntfs3: Use variable length array instead of fixed size
   fs/ntfs3: Use 64 bit variable to avoid 32 bit overflow
   fs/ntfs3: Redesign ntfs_create_inode to return error code instead of
     inode
   fs/ntfs3: Check 'folio' pointer for NULL
   fs/ntfs3: Always make file nonresident if fallocate (xfstest 438)
   fs/ntfs3: Optimize to store sorted attribute definition table
   fs/ntfs3: Remove cached label from sbi
   fs/ntfs3: Taking DOS names into account during link counting

  fs/ntfs3/attrib.c  | 103 ++++++++++++++++++++++++++++++++
  fs/ntfs3/file.c    |   9 +++
  fs/ntfs3/fslog.c   |   5 +-
  fs/ntfs3/fsntfs.c  |  77 ++++++++++++++++++++----
  fs/ntfs3/inode.c   |  76 ++++++++++++-----------
  fs/ntfs3/namei.c   |  31 +++-------
  fs/ntfs3/ntfs.h    |   6 +-
  fs/ntfs3/ntfs_fs.h |  77 +++++++++++++++---------
  fs/ntfs3/record.c  |  11 +---
  fs/ntfs3/super.c   | 146 +++++++++++++++++++--------------------------
  fs/ntfs3/xattr.c   |  23 ++++---
  11 files changed, 355 insertions(+), 209 deletions(-)

Comments

Johan Hovold April 18, 2024, 6:42 a.m. UTC | #1

On Wed, Apr 17, 2024 at 04:03:46PM +0300, Konstantin Komarov wrote:
> This series contains various fixes and refactoring for ntfs3.
> Fixed problem with incorrect link counting for files with DOS names.
>
> Konstantin Komarov (11):
>    fs/ntfs3: Remove max link count info display during driver init
>    fs/ntfs3: Missed le32_to_cpu conversion
>    fs/ntfs3: Mark volume as dirty if xattr is broken
>    fs/ntfs3: Use variable length array instead of fixed size
>    fs/ntfs3: Use 64 bit variable to avoid 32 bit overflow
>    fs/ntfs3: Redesign ntfs_create_inode to return error code instead of
>      inode
>    fs/ntfs3: Check 'folio' pointer for NULL
>    fs/ntfs3: Always make file nonresident if fallocate (xfstest 438)
>    fs/ntfs3: Optimize to store sorted attribute definition table
>    fs/ntfs3: Remove cached label from sbi
>    fs/ntfs3: Taking DOS names into account during link counting

All the patches in this series appear to be white space damaged and
cannot be applied.

Most of the patches are lacking proper commit messages, and the bug
fixes should be clearly marked as such with a Fixes tag and CC-stable
tag where appropriate.

Also don't mix fixes with cleanups and refactoring unless the former
really depends on the latter.

At least move the independent fixes to the front of the series.

Johan