mbox series

[0/2] fuse: fix up uid/gid mount option handling

Message ID 89e18d62-3b2d-45db-94f3-41edc4232955@redhat.com (mailing list archive)
Headers show
Series fuse: fix up uid/gid mount option handling | expand

Message

Eric Sandeen July 2, 2024, 10:12 p.m. UTC
This short series fixes up fuse uid/gid mount option handling.

First, as was done for tmpfs in 
0200679fc795 ("tmpfs: verify {g,u}id mount options correctly")
it validates that the requested uid and/or gid is representable in
the filesystem's idmapping. I've shamelessly copied commit description
and code from that commit.

Second, it is switched to use the uid/gid mount helpers proposed at
https://lore.kernel.org/linux-fsdevel/8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com/T/#t

Both of these are compile-tested only.

Thanks,
-Eric

Comments

Christian Brauner July 3, 2024, 8:38 a.m. UTC | #1
On Tue, Jul 02, 2024 at 05:12:18PM GMT, Eric Sandeen wrote:
> This short series fixes up fuse uid/gid mount option handling.
> 
> First, as was done for tmpfs in 
> 0200679fc795 ("tmpfs: verify {g,u}id mount options correctly")
> it validates that the requested uid and/or gid is representable in
> the filesystem's idmapping. I've shamelessly copied commit description
> and code from that commit.
> 
> Second, it is switched to use the uid/gid mount helpers proposed at
> https://lore.kernel.org/linux-fsdevel/8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com/T/#t

Reviewed-by: Christian Brauner <brauner@kernel.org>
Josef Bacik July 3, 2024, 2:46 p.m. UTC | #2
On Tue, Jul 02, 2024 at 05:12:18PM -0500, Eric Sandeen wrote:
> This short series fixes up fuse uid/gid mount option handling.
> 
> First, as was done for tmpfs in 
> 0200679fc795 ("tmpfs: verify {g,u}id mount options correctly")
> it validates that the requested uid and/or gid is representable in
> the filesystem's idmapping. I've shamelessly copied commit description
> and code from that commit.
> 
> Second, it is switched to use the uid/gid mount helpers proposed at
> https://lore.kernel.org/linux-fsdevel/8dca3c11-99f4-446d-a291-35c50ed2dc14@redhat.com/T/#t
> 
> Both of these are compile-tested only.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef
Christian Brauner July 3, 2024, 2:58 p.m. UTC | #3
On Tue, 02 Jul 2024 17:12:18 -0500, Eric Sandeen wrote:
> This short series fixes up fuse uid/gid mount option handling.
> 
> First, as was done for tmpfs in
> 0200679fc795 ("tmpfs: verify {g,u}id mount options correctly")
> it validates that the requested uid and/or gid is representable in
> the filesystem's idmapping. I've shamelessly copied commit description
> and code from that commit.
> 
> [...]

Miklos, I've taken this because I have the required helper in vfs.mount.api.
But if you want to take it just tell me then I can give you a stable branch so
that you can pull the helper.

---

Applied to the vfs.mount.api branch of the vfs/vfs.git tree.
Patches in the vfs.mount.api branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.mount.api

[1/2] fuse: verify {g,u}id mount options correctly
      https://git.kernel.org/vfs/vfs/c/525bd65aa759
[2/2] fuse: Convert to new uid/gid option parsing helpers
      https://git.kernel.org/vfs/vfs/c/eea6a8322efd