mbox series

[v2,0/7] exfat: code optimizations

Message ID PUZPR04MB6316B3802565F2A09DD0D47A81E39@PUZPR04MB6316.apcprd04.prod.outlook.com (mailing list archive)
Headers show
Series exfat: code optimizations | expand

Message

Yuezhang.Mo@sony.com Dec. 13, 2022, 2:36 a.m. UTC 
This patchset is some minor code optimizations, no functional changes.

Changes for v2:
  - [6/7] [7/7] Fix return value type of exfat_sector_to_cluster()

Yuezhang Mo (7):
  exfat: remove call ilog2() from exfat_readdir()
  exfat: remove unneeded codes from __exfat_rename()
  exfat: remove unnecessary arguments from exfat_find_dir_entry()
  exfat: remove argument 'size' from exfat_truncate()
  exfat: remove i_size_write() from __exfat_truncate()
  exfat: fix overflow in sector and cluster conversion
  exfat: reuse exfat_find_location() to simplify exfat_get_dentry_set()

 fs/exfat/dir.c      | 38 +++++++++++++++-----------------------
 fs/exfat/exfat_fs.h | 19 ++++++++++++-------
 fs/exfat/file.c     | 12 +++++-------
 fs/exfat/inode.c    |  4 ++--
 fs/exfat/namei.c    | 19 +++----------------
 5 files changed, 37 insertions(+), 55 deletions(-)

Comments

Sungjong Seo Dec. 13, 2022, 6:06 a.m. UTC | #1 
> This patchset is some minor code optimizations, no functional changes.
> 
> Changes for v2:
>   - [6/7] [7/7] Fix return value type of exfat_sector_to_cluster()

Looks good. Thanks.
Reviewed-by: Sungjong Seo <sj1557.seo@samsung.com>

> 
> Yuezhang Mo (7):
>   exfat: remove call ilog2() from exfat_readdir()
>   exfat: remove unneeded codes from __exfat_rename()
>   exfat: remove unnecessary arguments from exfat_find_dir_entry()
>   exfat: remove argument 'size' from exfat_truncate()
>   exfat: remove i_size_write() from __exfat_truncate()
>   exfat: fix overflow in sector and cluster conversion
>   exfat: reuse exfat_find_location() to simplify exfat_get_dentry_set()
> 
>  fs/exfat/dir.c      | 38 +++++++++++++++-----------------------
>  fs/exfat/exfat_fs.h | 19 ++++++++++++-------
>  fs/exfat/file.c     | 12 +++++-------
>  fs/exfat/inode.c    |  4 ++--
>  fs/exfat/namei.c    | 19 +++----------------
>  5 files changed, 37 insertions(+), 55 deletions(-)
> 
> --
> 2.25.1
Namjae Jeon Dec. 13, 2022, 11:29 a.m. UTC | #2 
2022-12-13 11:36 GMT+09:00, Yuezhang.Mo@sony.com <Yuezhang.Mo@sony.com>:
> This patchset is some minor code optimizations, no functional changes.
Applied, Thanks for your patches!
>
> Changes for v2:
>   - [6/7] [7/7] Fix return value type of exfat_sector_to_cluster()
>
> Yuezhang Mo (7):
>   exfat: remove call ilog2() from exfat_readdir()
>   exfat: remove unneeded codes from __exfat_rename()
>   exfat: remove unnecessary arguments from exfat_find_dir_entry()
>   exfat: remove argument 'size' from exfat_truncate()
>   exfat: remove i_size_write() from __exfat_truncate()
>   exfat: fix overflow in sector and cluster conversion
>   exfat: reuse exfat_find_location() to simplify exfat_get_dentry_set()
>
>  fs/exfat/dir.c      | 38 +++++++++++++++-----------------------
>  fs/exfat/exfat_fs.h | 19 ++++++++++++-------
>  fs/exfat/file.c     | 12 +++++-------
>  fs/exfat/inode.c    |  4 ++--
>  fs/exfat/namei.c    | 19 +++----------------
>  5 files changed, 37 insertions(+), 55 deletions(-)
>
> --
> 2.25.1
>