[0/2] vfs: convert debugfs & tracefs to the new mount API

Message

Eric Sandeen March 5, 2024, 11:07 p.m. UTC

Since debugfs and tracefs are cut & pasted one way or the other,
do these at the same time.

Both of these patches originated in dhowells' tree at
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=mount-api-viro

https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-api-viro&id=ec14be9e2aa76f63458466bba86256e123ec4e51
and
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-api-viro&id=c4f2e60465859e02a6e36ed618dbaea16de8c8e0

I've forward-ported them to the mount API that landed, and
fixed up remounting; ->reconfigure() needed to copy the
parsed context options into the current superblock options
to effect any remount changes.

While these do use the invalf() functions for some errors, they
are new messages, not messages that used to go to dmesg that
would be lost if userspace isn't listening.

I've done minimal testing - booting with the patches, testing
some of the remount behavior for mode & uid.
Oh, and I built it too. </brown_paper_bag>

thanks,
-Eric

Comments

Christian Brauner March 6, 2024, 10:57 a.m. UTC | #1

On Tue, Mar 05, 2024 at 05:07:29PM -0600, Eric Sandeen wrote:
> Since debugfs and tracefs are cut & pasted one way or the other,
> do these at the same time.
> 
> Both of these patches originated in dhowells' tree at
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=mount-api-viro
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-api-viro&id=ec14be9e2aa76f63458466bba86256e123ec4e51
> and
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-api-viro&id=c4f2e60465859e02a6e36ed618dbaea16de8c8e0
> 
> I've forward-ported them to the mount API that landed, and
> fixed up remounting; ->reconfigure() needed to copy the
> parsed context options into the current superblock options
> to effect any remount changes.
> 
> While these do use the invalf() functions for some errors, they
> are new messages, not messages that used to go to dmesg that
> would be lost if userspace isn't listening.
> 
> I've done minimal testing - booting with the patches, testing
> some of the remount behavior for mode & uid.
> Oh, and I built it too. </brown_paper_bag>

Looks ok to me.

Christian Brauner March 12, 2024, 2:35 p.m. UTC | #2

On Tue, 05 Mar 2024 17:07:29 -0600, Eric Sandeen wrote:
> Since debugfs and tracefs are cut & pasted one way or the other,
> do these at the same time.
> 
> Both of these patches originated in dhowells' tree at
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=mount-api-viro
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-api-viro&id=ec14be9e2aa76f63458466bba86256e123ec4e51
> and
> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=mount-api-viro&id=c4f2e60465859e02a6e36ed618dbaea16de8c8e0
> 
> [...]

I'm assuming that your Acks meant I'm good to pick those up.
Please yell, if not!

---

Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/2] vfs: Convert debugfs to use the new mount API
      https://git.kernel.org/vfs/vfs/c/393b0b4c609e
[2/2] vfs: Convert tracefs to use the new mount API
      https://git.kernel.org/vfs/vfs/c/140a2056102a