[RFCv2,0/5] ext4: misc left over folio changes

Message

Ritesh Harjani (IBM) May 15, 2023, 10:40 a.m. UTC

Hello,

Please find v2 of the left over folio conversion changes.
It would be nice if you could also review Patch-2 and Patch-4.

v1 -> v2
=========
1. Added Patch-2 which removes PAGE_SIZE assumption from mpage_submit_folio.
   (IMO, this was a missed left over from previous conversion).
2. Addressed a small review comment from Matthew in the tracepoint patch to take
   (inode, folio).
3. Added Reviewed-by from Matthew.

Testing
========
I haven't found any new failures in my fstests testing with "-g auto" with
default config.

Ritesh Harjani (IBM) (5):
  ext4: kill unused function ext4_journalled_write_inline_data
  ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio
  ext4: Change remaining tracepoints to use folio
  ext4: Make mpage_journal_page_buffers use folio
  ext4: Make ext4_write_inline_data_end() use folio

 fs/ext4/ext4.h              | 10 ++-----
 fs/ext4/inline.c            | 27 +----------------
 fs/ext4/inode.c             | 60 ++++++++++++++++++++-----------------
 include/trace/events/ext4.h | 26 ++++++++--------
 4 files changed, 48 insertions(+), 75 deletions(-)

--
2.40.1

Comments

Theodore Ts'o June 9, 2023, 3:14 a.m. UTC | #1

On Mon, 15 May 2023 16:10:39 +0530, Ritesh Harjani (IBM) wrote:
> Please find v2 of the left over folio conversion changes.
> It would be nice if you could also review Patch-2 and Patch-4.
> 
> v1 -> v2
> =========
> 1. Added Patch-2 which removes PAGE_SIZE assumption from mpage_submit_folio.
>    (IMO, this was a missed left over from previous conversion).
> 2. Addressed a small review comment from Matthew in the tracepoint patch to take
>    (inode, folio).
> 3. Added Reviewed-by from Matthew.
> 
> [...]

Applied, thanks!

[1/5] ext4: kill unused function ext4_journalled_write_inline_data
      commit: 40fa8be3852ff7a7b3708c6a69c9eacf98da6612
[2/5] ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio
      commit: 732572e95427fe9f68197c60074b750242b84944
[3/5] ext4: Change remaining tracepoints to use folio
      commit: 263619455efcd0deb1f8c24f2895f48751a1d679
[4/5] ext4: Make mpage_journal_page_buffers use folio
      commit: 13004fbc85f58b05cfeb72372b418b6aa1caddc5
[5/5] ext4: Make ext4_write_inline_data_end() use folio
      commit: 04a8b77b66c5bea74b60cc2f5230a851b4ade096
[6/6] ext4: Call fsverity_verify_folio()
      commit: 60469ab9340529a607574a7b6ab6483217607a75

Best regards,