From patchwork Fri Dec 29 08:36:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 13506400 Received: from mout.web.de (mout.web.de [212.227.15.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3189A7487; Fri, 29 Dec 2023 08:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="Z/oPI3az" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703838996; x=1704443796; i=markus.elfring@web.de; bh=EoV9yLqj2IKlvd3kf0dcQWQx2nrQ9IxzgPGR8PzE6gk=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=Z/oPI3azC3HJv1dDkXwpJ6y+y1ZXORefODhZkdQmPC/o8G6JvkwCIbdL8N/idiZd vPifSJqtlGPbdMVa99vx4Qp3z9mizut3WV5LHa/j5VY2MmGLuo51ZlyC4ILmSMAF7 3kfLzPW6U9MnoTArmFknLUNqcw0qO4OXKjwWNwR9vatw1zezfEM4ygORwEjMwrRsZ 391ksx4EQ8oON3K6lGn67mk2ToZWnYAOOCEGx7FxDiJnuD3cLhtK9G35IP7G1v/ji rBo9Eh/bv2CYurwtgPuvLEXLtzirOEG6pzc1k0XKUDCufEAYek352ehdRdNM8RUSb S29s1xeQotkrSXXU1w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MQxs3-1rdqAF30lD-00Ntio; Fri, 29 Dec 2023 09:36:36 +0100 Message-ID: <02fe18da-55f5-47c5-a297-58411edbb78b@web.de> Date: Fri, 29 Dec 2023 09:36:36 +0100 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/2] virtiofs: Improve three size determinations Content-Language: en-GB From: Markus Elfring To: virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, Miklos Szeredi , Stefan Hajnoczi , Vivek Goyal Cc: LKML References: In-Reply-To: X-Provags-ID: V03:K1:wr5P/Bg9PxNgJIoMgfNzDUkyUJzJDLFq8qyCn+DoP/ZmDJNaPgr LGvRriMUINRI8yNKGzgo2Se4snoKcqsP7uNsGz4lj4lMTbaFYczcfgR6Gmik32RTFSMDMUO 8AHm242rwxLVhEOFcDbxak31RD5rVwoLqTEl/3Y15Xv8uA6c2gc4dJwfa+aCgUiYZ7hNbwE x7po+0SYR+dNYEW1aCClQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PTLJh/rv7EE=;XPTFsDCeIhprv+w64gnTHhnRgWk Vorh+H7NvdWvL4QBjJVp2rHmHHdJiuPWrXarQvs8VPavUI9t/7tYlKtmadBTi4dAx4psLExdX b8u1qaS5ElAQEhcopVwP6xcZenBurB9v4ah8MTlcgszJdYrhXHJmow9sRIqj/s1NBt3xXNF/m YzU4b4+c6OY9zOWQ0G4QFoFNGvpkunP7Zrk9OVhiFkiytECWtQBCuNAKsdu0lkp+l+QOAppQv g3CM+dgPiOJnyV+eXU2Aj3f7aTLs53zQDRvJYZNt7zMFCkb+jDDYG3NVs7GGGSgtMEMnkS6qe WXrKY/HhNWo3l1KZY3io/GWZenYqPEcVbuhn55SYWO4vKN/7FiFii35tboFLjNuXOUxGoHtsi uKiGXmnTh3bvtGYzt/K8fCyKgdTpcLaW7SHUtp93zYaZU0Z68CT47qvzzC8LtFPUaOv+Z4zqK 8H9nvYxgOy5E1M1lDoStYnGp62lsaqa5S47kI7ji/4u5GZXrI7hQso3Ep3eE/+gA2HKOgmTm9 CvmdLcljIWacnsop5wlsikgM96DRT8iJpZZDXrVPOX/UYf+cwbICOhvluUdzcSVPgmRx4Dp/D 40RZXj/YB5mvM/dBfGFJbCPpM7e1bpjSyy80gjXInThK/xfNfy5IiznSKK0i/JPQOHLRSR3zl I8oSRaIAFOgLkHAEOSSNc+uRfoaNCwVDGUrmHXU486nEn3lqtd9jx738ohfZXHIcau+PHvaHd xFTFy09jRfM4DCGrz+BpfORArkG2oulfkMQW/1Mgca1K2Hyeo3VHCkCQTbUmIHxU58q3V85Ib JtI0urFD/R5/cPkpAnDAAWuNsq6aGAm0f32k6HkdzbPkuo8QlXrsfpkTjwGgTp1feAvDIKafF 4wOVbVf+Q6ASPb64KTP9Cd/FmjFoaL4LZceZFN5/8Z3oTZxBQ1PkxchUQDhF7nZaHgF51KKAN PBQxwXmesP7aa59JyaMCTLZbAzE= From: Markus Elfring Date: Fri, 29 Dec 2023 08:42:04 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator “sizeof” to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/fuse/virtio_fs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.43.0 diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c index 5f1be1da92ce..2f8ba9254c1e 100644 --- a/fs/fuse/virtio_fs.c +++ b/fs/fuse/virtio_fs.c @@ -1435,11 +1435,11 @@ static int virtio_fs_get_tree(struct fs_context *fsc) goto out_err; err = -ENOMEM; - fc = kzalloc(sizeof(struct fuse_conn), GFP_KERNEL); + fc = kzalloc(sizeof(*fc), GFP_KERNEL); if (!fc) goto out_err; - fm = kzalloc(sizeof(struct fuse_mount), GFP_KERNEL); + fm = kzalloc(sizeof(*fm), GFP_KERNEL); if (!fm) goto out_err; @@ -1495,7 +1495,7 @@ static int virtio_fs_init_fs_context(struct fs_context *fsc) if (fsc->purpose == FS_CONTEXT_FOR_SUBMOUNT) return fuse_init_fs_context_submount(fsc); - ctx = kzalloc(sizeof(struct fuse_fs_context), GFP_KERNEL); + ctx = kzalloc(sizeof(*ctx), GFP_KERNEL); if (!ctx) return -ENOMEM; fsc->fs_private = ctx;