From patchwork Wed May 13 22:26:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Viro X-Patchwork-Id: 6400931 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4145CBEEE1 for ; Wed, 13 May 2015 22:30:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 63DF8203EB for ; Wed, 13 May 2015 22:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C17820320 for ; Wed, 13 May 2015 22:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965424AbbEMW3h (ORCPT ); Wed, 13 May 2015 18:29:37 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:44945 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965510AbbEMW0V (ORCPT ); Wed, 13 May 2015 18:26:21 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.76 #1 (Red Hat Linux)) id 1Ysf6W-0006mL-5x; Wed, 13 May 2015 22:26:16 +0000 From: Al Viro To: Linus Torvalds Cc: Neil Brown , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 10/21] namei: shift nameidata inside filename_lookup() Date: Wed, 13 May 2015 23:26:04 +0100 Message-Id: <1431555975-25997-10-git-send-email-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <20150513222533.GA24192@ZenIV.linux.org.uk> References: <20150513222533.GA24192@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Al Viro pass root instead; non-NULL => copy to nd.root and set LOOKUP_ROOT in flags Signed-off-by: Al Viro --- fs/namei.c | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 17350c0..abf65b0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2117,17 +2117,20 @@ static int path_lookupat(int dfd, const struct filename *name, unsigned flags, } static int filename_lookup(int dfd, struct filename *name, unsigned flags, - struct nameidata *nd, struct path *path) + struct path *path, struct path *root) { int retval; - struct nameidata *saved_nd = set_nameidata(nd); - - retval = path_lookupat(dfd, name, flags | LOOKUP_RCU, nd, path); + struct nameidata nd, *saved_nd = set_nameidata(&nd); + if (unlikely(root)) { + nd.root = *root; + flags |= LOOKUP_ROOT; + } + retval = path_lookupat(dfd, name, flags | LOOKUP_RCU, &nd, path); if (unlikely(retval == -ECHILD)) - retval = path_lookupat(dfd, name, flags, nd, path); + retval = path_lookupat(dfd, name, flags, &nd, path); if (unlikely(retval == -ESTALE)) retval = path_lookupat(dfd, name, flags | LOOKUP_REVAL, - nd, path); + &nd, path); if (likely(!retval)) audit_inode(name, path->dentry, flags & LOOKUP_PARENT); @@ -2207,11 +2210,10 @@ out: int kern_path(const char *name, unsigned int flags, struct path *path) { - struct nameidata nd; struct filename *filename = getname_kernel(name); if (IS_ERR(filename)) return PTR_ERR(filename); - return filename_lookup(AT_FDCWD, filename, flags, &nd, path); + return filename_lookup(AT_FDCWD, filename, flags, path, NULL); } EXPORT_SYMBOL(kern_path); @@ -2227,7 +2229,7 @@ int vfs_path_lookup(struct dentry *dentry, struct vfsmount *mnt, const char *name, unsigned int flags, struct path *path) { - struct nameidata nd; + struct path root = {.mnt = mnt, .dentry = dentry}; struct filename *filename = getname_kernel(name); BUG_ON(flags & LOOKUP_PARENT); @@ -2235,11 +2237,8 @@ int vfs_path_lookup(struct dentry *dentry, struct vfsmount *mnt, if (IS_ERR(filename)) return PTR_ERR(filename); - nd.root.dentry = dentry; - nd.root.mnt = mnt; - /* the first argument of filename_lookup() is ignored with LOOKUP_ROOT */ - return filename_lookup(AT_FDCWD, filename, - flags | LOOKUP_ROOT, &nd, path); + /* the first argument of filename_lookup() is ignored with root */ + return filename_lookup(AT_FDCWD, filename, flags , path, &root); } EXPORT_SYMBOL(vfs_path_lookup); @@ -2297,14 +2296,13 @@ EXPORT_SYMBOL(lookup_one_len); int user_path_at_empty(int dfd, const char __user *name, unsigned flags, struct path *path, int *empty) { - struct nameidata nd; struct filename *tmp = getname_flags(name, flags, empty); if (IS_ERR(tmp)) return PTR_ERR(tmp); BUG_ON(flags & LOOKUP_PARENT); - return filename_lookup(dfd, tmp, flags, &nd, path); + return filename_lookup(dfd, tmp, flags, path, NULL); } int user_path_at(int dfd, const char __user *name, unsigned flags,