From patchwork Mon May 18 11:34:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Copeland X-Patchwork-Id: 6428401 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A67B5C0432 for ; Mon, 18 May 2015 11:37:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C2899205EF for ; Mon, 18 May 2015 11:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D336820274 for ; Mon, 18 May 2015 11:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753778AbbERLhh (ORCPT ); Mon, 18 May 2015 07:37:37 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:38791 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804AbbERLhc (ORCPT ); Mon, 18 May 2015 07:37:32 -0400 Received: by igcau1 with SMTP id au1so44724919igc.1 for ; Mon, 18 May 2015 04:37:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VBaaXrUMwaSKDRO/5aqPLavAYmi3+B/TqE6y8MloT9I=; b=OEV4ivzEn7nEw22rPL1tw1BBtXOxtpwcnz8uihBwtuuowWWF1rRz2RDvKo+kJz0tJL QaxwSYzNO94MbKmtqgAq+bLcsGkCv3tzZ6f5O36TrT58vA52l2wCR6e+zcabOrHZK2QW gyxgH8qUPO/d3vFZCs097S0wLlrqhxmqADf6JFVQVIGj7NYP/QvuEcAQ4QU40YrTSq3g M4EcFTJVQMlJRp0curD9FYKzwgEJ/jrLpzlKZCfJn527sshtpm9NMxjN0hbTqr7Ynlwn yOKnGrYCLw7hydnMEJ5emXQWHeapnxn0nWHWVKzgnn/F6UuNX/EzDnU/Ap3mCYkbWqFE LuMA== X-Gm-Message-State: ALoCoQnYiX4266vPcJ1lPtoRgH8pH9pOwvqTm39YA+eudbqtRq0X7CyZf6Zn3lK5aHK4dp2jd/HG X-Received: by 10.50.62.148 with SMTP id y20mr13675796igr.17.1431949051610; Mon, 18 May 2015 04:37:31 -0700 (PDT) Received: from hash ([2001:470:1d:6db:230:48ff:fe9d:9c89]) by mx.google.com with ESMTPSA id h138sm7514470ioe.2.2015.05.18.04.37.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 04:37:30 -0700 (PDT) Received: from glass.lan ([192.168.1.51] helo=glass) by hash with esmtp (Exim 4.84) (envelope-from ) id 1YuJMI-0005dR-Me; Mon, 18 May 2015 07:37:22 -0400 Received: from bob by glass with local (Exim 4.84) (envelope-from ) id 1YuJKF-0000zf-Bn; Mon, 18 May 2015 07:35:15 -0400 From: Bob Copeland To: akpm@linux-foundation.org Cc: linux-fsdevel@vger.kernel.org, Bob Copeland Subject: [PATCH 4/4] omfs: fix potential integer overflow in allocator Date: Mon, 18 May 2015 07:34:38 -0400 Message-Id: <1431948878-3756-5-git-send-email-me@bobcopeland.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431948878-3756-1-git-send-email-me@bobcopeland.com> References: <1431948878-3756-1-git-send-email-me@bobcopeland.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Both 'i' and 'bits_per_entry' are signed integers but the result is a u64 block number. Cast i to u64 to avoid truncation on 32-bit targets. Found by Coverity (CID 200679). Signed-off-by: Bob Copeland --- fs/omfs/bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/omfs/bitmap.c b/fs/omfs/bitmap.c index 082234581d05..83f4e76511c2 100644 --- a/fs/omfs/bitmap.c +++ b/fs/omfs/bitmap.c @@ -159,7 +159,7 @@ int omfs_allocate_range(struct super_block *sb, goto out; found: - *return_block = i * bits_per_entry + bit; + *return_block = (u64) i * bits_per_entry + bit; *return_size = run; ret = set_run(sb, i, bits_per_entry, bit, run, 1);