| Message ID | 1433163603-13229-3-git-send-email-mhocko@suse.cz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Does anybody have a better idea how to deal with the issue mentioned in the patch? Or is it considered uninteresting and not worth bothering? I am not worried about the current state but if we want to allow GFP_NOFS allocations to fail (I have a series of patches to do so and plan to post an RFC soon) to actually allow the user of the allocator to have fallback strategies then we do not want to keep this side way to premature OOM killer open, right? On Mon 01-06-15 15:00:03, Michal Hocko wrote: > page_cache_read has been historically using page_cache_alloc_cold to > allocate a new page. This means that mapping_gfp_mask is used as the > base for the gfp_mask. Many filesystems are setting this mask to > GFP_NOFS to prevent from fs recursion issues. page_cache_read is, > however, not called from the fs layera directly so it doesn't need this > protection normally. > > ceph and ocfs2 which call filemap_fault from their fault handlers > seem to be OK because they are not taking any fs lock before invoking > generic implementation. xfs which takes XFS_MMAPLOCK_SHARED is safe > from the reclaim recursion POV because this lock serializes truncate > and punch hole with the page faults and it doesn't get involved in the > reclaim. > > The GFP_NOFS protection might be even harmful. There is a push to fail > GFP_NOFS allocations rather than loop within allocator indefinitely with > a very limited reclaim ability. Once we start failing those requests > the OOM killer might be triggered prematurely because the page cache > allocation failure is propagated up the page fault path and end up in > pagefault_out_of_memory. > > We cannot play with mapping_gfp_mask directly because that would be racy > wrt. parallel page faults and it might interfere with other users who > really rely on NOFS semantic from the stored gfp_mask. The mask is also > inode proper so it would even be a layering violation. What we can do > instead is to push the gfp_mask into struct vm_fault and allow fs layer > to overwrite it should the callback need to be called with a different > allocation context. > > Initialize the default to (mapping_gfp_mask | GFP_IOFS) because this > should be safe from the page fault path normally. Why do we care > about mapping_gfp_mask at all then? Because this doesn't hold only > reclaim protection flags but it also might contain zone and movability > restrictions (GFP_DMA32, __GFP_MOVABLE and others) so we have to respect > those. > > Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Signed-off-by: Michal Hocko <mhocko@suse.cz> > --- > include/linux/mm.h | 4 ++++ > mm/filemap.c | 9 ++++----- > mm/memory.c | 17 +++++++++++++++++ > 3 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 76376e04988a..03b8420e123c 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -219,10 +219,14 @@ extern pgprot_t protection_map[16]; > * ->fault function. The vma's ->fault is responsible for returning a bitmask > * of VM_FAULT_xxx flags that give details about how the fault was handled. > * > + * MM layer fills up gfp_mask for page allocations but fault handler might > + * alter it if its implementation requires a different allocation context. > + * > * pgoff should be used in favour of virtual_address, if possible. > */ > struct vm_fault { > unsigned int flags; /* FAULT_FLAG_xxx flags */ > + gfp_t gfp_mask; /* gfp mask to be used for allocations */ > pgoff_t pgoff; /* Logical page offset based on vma */ > void __user *virtual_address; /* Faulting virtual address */ > > diff --git a/mm/filemap.c b/mm/filemap.c > index adfc5d2e21c8..bfbc30ff47a4 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -1760,19 +1760,18 @@ EXPORT_SYMBOL(generic_file_read_iter); > * This adds the requested page to the page cache if it isn't already there, > * and schedules an I/O to read in its contents from disk. > */ > -static int page_cache_read(struct file *file, pgoff_t offset) > +static int page_cache_read(struct file *file, pgoff_t offset, gfp_t gfp_mask) > { > struct address_space *mapping = file->f_mapping; > struct page *page; > int ret; > > do { > - page = page_cache_alloc_cold(mapping); > + page = __page_cache_alloc(gfp_mask|__GFP_COLD); > if (!page) > return -ENOMEM; > > - ret = add_to_page_cache_lru(page, mapping, offset, > - GFP_KERNEL & mapping_gfp_mask(mapping)); > + ret = add_to_page_cache_lru(page, mapping, offset, GFP_KERNEL & gfp_mask); > if (ret == 0) > ret = mapping->a_ops->readpage(file, page); > else if (ret == -EEXIST) > @@ -1955,7 +1954,7 @@ int filemap_fault(struct vm_area_struct *vma, struct vm_fault *vmf) > * We're only likely to ever get here if MADV_RANDOM is in > * effect. > */ > - error = page_cache_read(file, offset); > + error = page_cache_read(file, offset, vmf->gfp_mask); > > /* > * The page we want has now been added to the page cache. > diff --git a/mm/memory.c b/mm/memory.c > index 8a2fc9945b46..25ab29560dca 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1949,6 +1949,20 @@ static inline void cow_user_page(struct page *dst, struct page *src, unsigned lo > copy_user_highpage(dst, src, va, vma); > } > > +static gfp_t __get_fault_gfp_mask(struct vm_area_struct *vma) > +{ > + struct file *vm_file = vma->vm_file; > + > + if (vm_file) > + return mapping_gfp_mask(vm_file->f_mapping) | GFP_IOFS; > + > + /* > + * Special mappings (e.g. VDSO) do not have any file so fake > + * a default GFP_KERNEL for them. > + */ > + return GFP_KERNEL; > +} > + > /* > * Notify the address space that the page is about to become writable so that > * it can prohibit this or wait for the page to get into an appropriate state. > @@ -1964,6 +1978,7 @@ static int do_page_mkwrite(struct vm_area_struct *vma, struct page *page, > vmf.virtual_address = (void __user *)(address & PAGE_MASK); > vmf.pgoff = page->index; > vmf.flags = FAULT_FLAG_WRITE|FAULT_FLAG_MKWRITE; > + vmf.gfp_mask = __get_fault_gfp_mask(vma); > vmf.page = page; > vmf.cow_page = NULL; > > @@ -2763,6 +2778,7 @@ static int __do_fault(struct vm_area_struct *vma, unsigned long address, > vmf.pgoff = pgoff; > vmf.flags = flags; > vmf.page = NULL; > + vmf.gfp_mask = __get_fault_gfp_mask(vma); > vmf.cow_page = cow_page; > > ret = vma->vm_ops->fault(vma, &vmf); > @@ -2929,6 +2945,7 @@ static void do_fault_around(struct vm_area_struct *vma, unsigned long address, > vmf.pgoff = pgoff; > vmf.max_pgoff = max_pgoff; > vmf.flags = flags; > + vmf.gfp_mask = __get_fault_gfp_mask(vma); > vma->vm_ops->map_pages(vma, &vmf); > } > > -- > 2.1.4 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
diff --git a/include/linux/mm.h b/include/linux/mm.h index 76376e04988a..03b8420e123c 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -219,10 +219,14 @@ extern pgprot_t protection_map[16]; * ->fault function. The vma's ->fault is responsible for returning a bitmask * of VM_FAULT_xxx flags that give details about how the fault was handled. * + * MM layer fills up gfp_mask for page allocations but fault handler might + * alter it if its implementation requires a different allocation context. + * * pgoff should be used in favour of virtual_address, if possible. */ struct vm_fault { unsigned int flags; /* FAULT_FLAG_xxx flags */ + gfp_t gfp_mask; /* gfp mask to be used for allocations */ pgoff_t pgoff; /* Logical page offset based on vma */ void __user *virtual_address; /* Faulting virtual address */ diff --git a/mm/filemap.c b/mm/filemap.c index adfc5d2e21c8..bfbc30ff47a4 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1760,19 +1760,18 @@ EXPORT_SYMBOL(generic_file_read_iter); * This adds the requested page to the page cache if it isn't already there, * and schedules an I/O to read in its contents from disk. */ -static int page_cache_read(struct file *file, pgoff_t offset) +static int page_cache_read(struct file *file, pgoff_t offset, gfp_t gfp_mask) { struct address_space *mapping = file->f_mapping; struct page *page; int ret; do { - page = page_cache_alloc_cold(mapping); + page = __page_cache_alloc(gfp_mask|__GFP_COLD); if (!page) return -ENOMEM; - ret = add_to_page_cache_lru(page, mapping, offset, - GFP_KERNEL & mapping_gfp_mask(mapping)); + ret = add_to_page_cache_lru(page, mapping, offset, GFP_KERNEL & gfp_mask); if (ret == 0) ret = mapping->a_ops->readpage(file, page); else if (ret == -EEXIST) @@ -1955,7 +1954,7 @@ int filemap_fault(struct vm_area_struct *vma, struct vm_fault *vmf) * We're only likely to ever get here if MADV_RANDOM is in * effect. */ - error = page_cache_read(file, offset); + error = page_cache_read(file, offset, vmf->gfp_mask); /* * The page we want has now been added to the page cache. diff --git a/mm/memory.c b/mm/memory.c index 8a2fc9945b46..25ab29560dca 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1949,6 +1949,20 @@ static inline void cow_user_page(struct page *dst, struct page *src, unsigned lo copy_user_highpage(dst, src, va, vma); } +static gfp_t __get_fault_gfp_mask(struct vm_area_struct *vma) +{ + struct file *vm_file = vma->vm_file; + + if (vm_file) + return mapping_gfp_mask(vm_file->f_mapping) | GFP_IOFS; + + /* + * Special mappings (e.g. VDSO) do not have any file so fake + * a default GFP_KERNEL for them. + */ + return GFP_KERNEL; +} + /* * Notify the address space that the page is about to become writable so that * it can prohibit this or wait for the page to get into an appropriate state. @@ -1964,6 +1978,7 @@ static int do_page_mkwrite(struct vm_area_struct *vma, struct page *page, vmf.virtual_address = (void __user *)(address & PAGE_MASK); vmf.pgoff = page->index; vmf.flags = FAULT_FLAG_WRITE|FAULT_FLAG_MKWRITE; + vmf.gfp_mask = __get_fault_gfp_mask(vma); vmf.page = page; vmf.cow_page = NULL; @@ -2763,6 +2778,7 @@ static int __do_fault(struct vm_area_struct *vma, unsigned long address, vmf.pgoff = pgoff; vmf.flags = flags; vmf.page = NULL; + vmf.gfp_mask = __get_fault_gfp_mask(vma); vmf.cow_page = cow_page; ret = vma->vm_ops->fault(vma, &vmf); @@ -2929,6 +2945,7 @@ static void do_fault_around(struct vm_area_struct *vma, unsigned long address, vmf.pgoff = pgoff; vmf.max_pgoff = max_pgoff; vmf.flags = flags; + vmf.gfp_mask = __get_fault_gfp_mask(vma); vma->vm_ops->map_pages(vma, &vmf); }
page_cache_read has been historically using page_cache_alloc_cold to allocate a new page. This means that mapping_gfp_mask is used as the base for the gfp_mask. Many filesystems are setting this mask to GFP_NOFS to prevent from fs recursion issues. page_cache_read is, however, not called from the fs layera directly so it doesn't need this protection normally. ceph and ocfs2 which call filemap_fault from their fault handlers seem to be OK because they are not taking any fs lock before invoking generic implementation. xfs which takes XFS_MMAPLOCK_SHARED is safe from the reclaim recursion POV because this lock serializes truncate and punch hole with the page faults and it doesn't get involved in the reclaim. The GFP_NOFS protection might be even harmful. There is a push to fail GFP_NOFS allocations rather than loop within allocator indefinitely with a very limited reclaim ability. Once we start failing those requests the OOM killer might be triggered prematurely because the page cache allocation failure is propagated up the page fault path and end up in pagefault_out_of_memory. We cannot play with mapping_gfp_mask directly because that would be racy wrt. parallel page faults and it might interfere with other users who really rely on NOFS semantic from the stored gfp_mask. The mask is also inode proper so it would even be a layering violation. What we can do instead is to push the gfp_mask into struct vm_fault and allow fs layer to overwrite it should the callback need to be called with a different allocation context. Initialize the default to (mapping_gfp_mask | GFP_IOFS) because this should be safe from the page fault path normally. Why do we care about mapping_gfp_mask at all then? Because this doesn't hold only reclaim protection flags but it also might contain zone and movability restrictions (GFP_DMA32, __GFP_MOVABLE and others) so we have to respect those. Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Signed-off-by: Michal Hocko <mhocko@suse.cz> --- include/linux/mm.h | 4 ++++ mm/filemap.c | 9 ++++----- mm/memory.c | 17 +++++++++++++++++ 3 files changed, 25 insertions(+), 5 deletions(-)