From patchwork Tue Aug 11 01:23:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaegeuk Kim X-Patchwork-Id: 6987401 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 43FE2C05AC for ; Tue, 11 Aug 2015 01:23:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 77985205C2 for ; Tue, 11 Aug 2015 01:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A112C205B1 for ; Tue, 11 Aug 2015 01:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933337AbbHKBXd (ORCPT ); Mon, 10 Aug 2015 21:23:33 -0400 Received: from mail.kernel.org ([198.145.29.136]:53834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933381AbbHKBXb (ORCPT ); Mon, 10 Aug 2015 21:23:31 -0400 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C3E22205B1; Tue, 11 Aug 2015 01:23:30 +0000 (UTC) Received: from localhost (mobile-166-171-249-023.mycingular.net [166.171.249.23]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3D7F205C4; Tue, 11 Aug 2015 01:23:29 +0000 (UTC) From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH 2/2] f2fs: skip checkpoint if there is no dirty segments Date: Mon, 10 Aug 2015 18:23:25 -0700 Message-Id: <1439256205-8906-2-git-send-email-jaegeuk@kernel.org> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1439256205-8906-1-git-send-email-jaegeuk@kernel.org> References: <1439256205-8906-1-git-send-email-jaegeuk@kernel.org> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We should avoid wrong checkpoints when there is no dirty segments. Signed-off-by: Jaegeuk Kim --- fs/f2fs/gc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index fcb263a..c4ed116 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -809,13 +809,14 @@ gc_more: if (unlikely(f2fs_cp_error(sbi))) goto stop; + if (!__get_victim(sbi, &segno, gc_type)) + goto stop; + if (gc_type == BG_GC && has_not_enough_free_secs(sbi, nfree)) { gc_type = FG_GC; write_checkpoint(sbi, &cpc); } - if (!__get_victim(sbi, &segno, gc_type)) - goto stop; ret = 0; /* readahead multi ssa blocks those have contiguous address */