diff mbox

sh: add copy_user_page() alias for __copy_user()

Message ID 1442958411-4271-1-git-send-email-ross.zwisler@linux.intel.com
State New
Headers show

Commit Message

Ross Zwisler Sept. 22, 2015, 9:46 p.m. UTC
copy_user_page() is needed by DAX.  Without this we get a compile error
for DAX on SH:

fs/dax.c:280:2: error: implicit declaration of function ‘copy_user_page’
[-Werror=implicit-function-declaration]
  copy_user_page(vto, (void __force *)vfrom, vaddr, to);
    ^

This was done with a random config that happened to include DAX support.

This patch has only been compile tested.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Apologies for the resend, I wanted to add some more recipients.
---
 arch/sh/include/asm/page.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Ross Zwisler Oct. 8, 2015, 11:07 p.m. UTC | #1
On Tue, Sep 22, 2015 at 03:46:51PM -0600, Ross Zwisler wrote:
> copy_user_page() is needed by DAX.  Without this we get a compile error
> for DAX on SH:
> 
> fs/dax.c:280:2: error: implicit declaration of function ‘copy_user_page’
> [-Werror=implicit-function-declaration]
>   copy_user_page(vto, (void __force *)vfrom, vaddr, to);
>     ^
> 
> This was done with a random config that happened to include DAX support.
> 
> This patch has only been compile tested.
> 
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Apologies for the resend, I wanted to add some more recipients.
> ---
>  arch/sh/include/asm/page.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/sh/include/asm/page.h b/arch/sh/include/asm/page.h
> index fe20d14..ceb5201 100644
> --- a/arch/sh/include/asm/page.h
> +++ b/arch/sh/include/asm/page.h
> @@ -59,6 +59,7 @@ pages_do_alias(unsigned long addr1, unsigned long addr2)
>  
>  #define clear_page(page)	memset((void *)(page), 0, PAGE_SIZE)
>  extern void copy_page(void *to, void *from);
> +#define copy_user_page(to, from, vaddr, pg)  __copy_user(to, from, PAGE_SIZE)
>  
>  struct page;
>  struct vm_area_struct;

Ping?
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Matt Fleming Oct. 12, 2015, 8:56 a.m. UTC | #2
On Thu, 08 Oct, at 05:07:34PM, Ross Zwisler wrote:
> On Tue, Sep 22, 2015 at 03:46:51PM -0600, Ross Zwisler wrote:
> > copy_user_page() is needed by DAX.  Without this we get a compile error
> > for DAX on SH:
> > 
> > fs/dax.c:280:2: error: implicit declaration of function ‘copy_user_page’
> > [-Werror=implicit-function-declaration]
> >   copy_user_page(vto, (void __force *)vfrom, vaddr, to);
> >     ^
> > 
> > This was done with a random config that happened to include DAX support.
> > 
> > This patch has only been compile tested.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> > Apologies for the resend, I wanted to add some more recipients.
> > ---
> >  arch/sh/include/asm/page.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/sh/include/asm/page.h b/arch/sh/include/asm/page.h
> > index fe20d14..ceb5201 100644
> > --- a/arch/sh/include/asm/page.h
> > +++ b/arch/sh/include/asm/page.h
> > @@ -59,6 +59,7 @@ pages_do_alias(unsigned long addr1, unsigned long addr2)
> >  
> >  #define clear_page(page)	memset((void *)(page), 0, PAGE_SIZE)
> >  extern void copy_page(void *to, void *from);
> > +#define copy_user_page(to, from, vaddr, pg)  __copy_user(to, from, PAGE_SIZE)
> >  
> >  struct page;
> >  struct vm_area_struct;
> 
> Ping?

Your best bet is probably to Cc Andrew (now Cc'd).

Andrew, original patch is here,

  https://lkml.kernel.org/r/1442958411-4271-1-git-send-email-ross.zwisler@linux.intel.com
diff mbox

Patch

diff --git a/arch/sh/include/asm/page.h b/arch/sh/include/asm/page.h
index fe20d14..ceb5201 100644
--- a/arch/sh/include/asm/page.h
+++ b/arch/sh/include/asm/page.h
@@ -59,6 +59,7 @@  pages_do_alias(unsigned long addr1, unsigned long addr2)
 
 #define clear_page(page)	memset((void *)(page), 0, PAGE_SIZE)
 extern void copy_page(void *to, void *from);
+#define copy_user_page(to, from, vaddr, pg)  __copy_user(to, from, PAGE_SIZE)
 
 struct page;
 struct vm_area_struct;