diff mbox

[07/17] fs/ext4: remove unnecessary new_valid_dev check

Message ID 1443448237-5285-1-git-send-email-bywxiaobai@163.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yaowei Bai Sept. 28, 2015, 1:50 p.m. UTC 
As new_valid_dev always returns 1, so !new_valid_dev check is not
needed, remove it.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
---
 fs/ext4/namei.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Theodore Ts'o Oct. 29, 2015, 6:09 p.m. UTC | #1 
On Mon, Sep 28, 2015 at 09:50:37PM +0800, Yaowei Bai wrote:
> As new_valid_dev always returns 1, so !new_valid_dev check is not
> needed, remove it.
> 
> Signed-off-by: Yaowei Bai <bywxiaobai@163.com>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yaowei Bai Oct. 30, 2015, 1:38 a.m. UTC | #2 
On Thu, Oct 29, 2015 at 02:09:01PM -0400, Theodore Ts'o wrote:
> On Mon, Sep 28, 2015 at 09:50:37PM +0800, Yaowei Bai wrote:
> > As new_valid_dev always returns 1, so !new_valid_dev check is not
> > needed, remove it.
> > 
> > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
> 
> Thanks, applied.

Ted, this patch has been merged into andrew's mm tree.

> 
> 					- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 9f61e76..41b6cc8 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2469,9 +2469,6 @@  static int ext4_mknod(struct inode *dir, struct dentry *dentry,
 	struct inode *inode;
 	int err, credits, retries = 0;
 
-	if (!new_valid_dev(rdev))
-		return -EINVAL;
-
 	err = dquot_initialize(dir);
 	if (err)
 		return err;