From patchwork Mon Sep 28 14:21:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yaowei Bai X-Patchwork-Id: 7277931 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4F81EBEEA4 for ; Mon, 28 Sep 2015 14:24:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8FEDF20718 for ; Mon, 28 Sep 2015 14:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCFD520717 for ; Mon, 28 Sep 2015 14:24:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933900AbbI1OXp (ORCPT ); Mon, 28 Sep 2015 10:23:45 -0400 Received: from m12-16.163.com ([220.181.12.16]:54946 "EHLO m12-16.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933806AbbI1OXo (ORCPT ); Mon, 28 Sep 2015 10:23:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=7jNaDPo4n9X47y+op6 QopywtiIHKLnOzKAU3WqF1yGI=; b=nyUYoSMgwv/jnzGqzCpmllNRG2rWHORJl8 2UYeMiBdkU6HsRkeztpvksxVZrHRUl0kmgyeuSZRnYSwO+iMULq1RFDxTRfJpmYR P/b6OTkGcLTKNvaeFqfbCfRLlb0IjUA7rN22RJUtMpCZQTsksMAUz8B9FnXR1adw I+F3c+vaU= Received: from localhost.localdomain (unknown [58.209.166.48]) by smtp12 (Coremail) with SMTP id EMCowED520thTQlW3pyWCQ--.46525S3; Mon, 28 Sep 2015 22:23:30 +0800 (CST) From: Yaowei Bai To: viro@zeniv.linux.org.uk, jack@suse.cz Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/17] fs/ext2: remove unnecessary new_valid_dev check Date: Mon, 28 Sep 2015 22:21:29 +0800 Message-Id: <1443450089-5555-1-git-send-email-bywxiaobai@163.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> References: <1443446807-4838-1-git-send-email-bywxiaobai@163.com> X-CM-TRANSID: EMCowED520thTQlW3pyWCQ--.46525S3 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUs-tIUUUUU X-Originating-IP: [58.209.166.48] X-CM-SenderInfo: xe1z5x5dretxi6rwjhhfrp/xtbBFAKDT1D+ZdAYNwABsv Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As new_valid_dev always returns 1, so !new_valid_dev check is not needed, remove it. Signed-off-by: Yaowei Bai --- fs/ext2/namei.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c index b4841e3..3267a80 100644 --- a/fs/ext2/namei.c +++ b/fs/ext2/namei.c @@ -143,9 +143,6 @@ static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode, struct inode * inode; int err; - if (!new_valid_dev(rdev)) - return -EINVAL; - err = dquot_initialize(dir); if (err) return err;