diff mbox

[v6,1/2] efi: export efi_capsule_supported() function symbol

Message ID 1443733554-22743-2-git-send-email-hock.leong.kweh@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Kweh Hock Leong Oct. 1, 2015, 9:05 p.m. UTC 
From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>

This patch export efi_capsule_supported() function symbol for capsule
kernel module to use.

Cc: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
---
 drivers/firmware/efi/capsule.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Borislav Petkov Oct. 2, 2015, 5:37 p.m. UTC | #1 
On Fri, Oct 02, 2015 at 05:05:53AM +0800, Kweh, Hock Leong wrote:
> From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
> 
> This patch export efi_capsule_supported() function symbol for capsule
> kernel module to use.
> 
> Cc: Matt Fleming <matt.fleming@intel.com>
> Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
> ---
>  drivers/firmware/efi/capsule.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c
> index d8cd75c0..738d437 100644
> --- a/drivers/firmware/efi/capsule.c
> +++ b/drivers/firmware/efi/capsule.c
> @@ -101,6 +101,7 @@ out:
>  	kfree(capsule);
>  	return rv;
>  }
> +EXPORT_SYMBOL_GPL(efi_capsule_supported);
>  
>  /**
>   * efi_capsule_update - send a capsule to the firmware

Why is this a separate patch?
Kweh Hock Leong Oct. 3, 2015, 3:02 a.m. UTC | #2 
> -----Original Message-----

> From: Borislav Petkov [mailto:bp@alien8.de]

> Sent: Saturday, October 03, 2015 1:37 AM

> To: Kweh, Hock Leong

> Cc: Matt Fleming; Greg Kroah-Hartman; Ong, Boon Leong; LKML; linux-

> efi@vger.kernel.org; Sam Protsenko; Peter Jones; Andy Lutomirski; Roy

> Franz; James Bottomley; Linux FS Devel; Fleming, Matt

> Subject: Re: [PATCH v6 1/2] efi: export efi_capsule_supported() function

> symbol

> 

> On Fri, Oct 02, 2015 at 05:05:53AM +0800, Kweh, Hock Leong wrote:

> > From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>

> >

> > This patch export efi_capsule_supported() function symbol for capsule

> > kernel module to use.

> >

> > Cc: Matt Fleming <matt.fleming@intel.com>

> > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>

> > ---

> >  drivers/firmware/efi/capsule.c |    1 +

> >  1 file changed, 1 insertion(+)

> >

> > diff --git a/drivers/firmware/efi/capsule.c

> > b/drivers/firmware/efi/capsule.c index d8cd75c0..738d437 100644

> > --- a/drivers/firmware/efi/capsule.c

> > +++ b/drivers/firmware/efi/capsule.c

> > @@ -101,6 +101,7 @@ out:

> >  	kfree(capsule);

> >  	return rv;

> >  }

> > +EXPORT_SYMBOL_GPL(efi_capsule_supported);

> >

> >  /**

> >   * efi_capsule_update - send a capsule to the firmware

> 

> Why is this a separate patch?

> 


It is because the author of this code is Matt. Submitting this,
allows him to easily squash into his patch:
https://lkml.org/lkml/2014/10/7/391

Thanks.
Borislav Petkov Oct. 3, 2015, 8:59 a.m. UTC | #3 
On Sat, Oct 03, 2015 at 03:02:11AM +0000, Kweh, Hock Leong wrote:
> It is because the author of this code is Matt. Submitting this,
> allows him to easily squash into his patch:
> https://lkml.org/lkml/2014/10/7/391

Then you should say that in the commit message or above it or under the
"---" line that this patch will either be merged into Matt's patchset or
you should simply merge it into your 2/2 patch when submitting.
diff mbox

Patch

diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c
index d8cd75c0..738d437 100644
--- a/drivers/firmware/efi/capsule.c
+++ b/drivers/firmware/efi/capsule.c
@@ -101,6 +101,7 @@  out:
 	kfree(capsule);
 	return rv;
 }
+EXPORT_SYMBOL_GPL(efi_capsule_supported);
 
 /**
  * efi_capsule_update - send a capsule to the firmware