From patchwork Fri Feb 5 16:08:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wouter van Kesteren X-Patchwork-Id: 8236681 Return-Path: X-Original-To: patchwork-linux-fsdevel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DA19C9F6DA for ; Fri, 5 Feb 2016 16:08:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0D44020384 for ; Fri, 5 Feb 2016 16:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C55C620383 for ; Fri, 5 Feb 2016 16:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbcBEQIm (ORCPT ); Fri, 5 Feb 2016 11:08:42 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34310 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754285AbcBEQIl (ORCPT ); Fri, 5 Feb 2016 11:08:41 -0500 Received: by mail-wm0-f47.google.com with SMTP id 128so76954575wmz.1 for ; Fri, 05 Feb 2016 08:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=FZoI5jOwC62TxH1MmT/5/lrxDvFLLcbCiRYqNo/nMUc=; b=B9prr9GX/W2h7wudE2zi7Mk+mRuPL+zSzXwY/LSXR+EfS6IEfzbvcgOgK2UEA3BVQw A4kBlPGAsGwi7EC9ndx97oFDZakffU+beny7baPA+JPBnbv5rWFkNFEU0ewt0dc5Ik+C lMUqphUpGvrSucLeF+7MuKlb54cVhQkwPSzzIsVbuFQ31ciU1Af9SMtMUnaUX+/uRhEP JmUCcfihvivt+fgBbd9uYNY9/SM0I2j1GtX5hSna7+vDXcy5nfBIJjISB0a5xaa4JxHo 0NMflszO/O7uiUJt7Qd2QE0PU5y6/8fkirgiqJIqbQY14hzDL1Psysgb08R/EANo8A+e 6CDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=FZoI5jOwC62TxH1MmT/5/lrxDvFLLcbCiRYqNo/nMUc=; b=QCA/y8/Q8LigYo/pMrPPb4ZKODwFAbmOay0GJuZ4M/h4YH00lsUqsskIoHf/P9So3i h+Ly/fkFpyJCcGUTJpVUXalWjdbQGj3qQCnCtA8dfATW5LNs6zpJXmKr1CgKoRzlbMwO ojjcrvbF75Mh0BRIRUbmsNABekYYSqLNLUH0u7peZJJAKwbSF4swdfKjnaftnJDAU/Fm PTbZmzn8jHA3fEuxKN3GkKA72Z1aJgogmdwHGu8m6+ocMqj4pND4ZdCP9mhJ/CXraqUu t+IVr8ocJ3osKsalWFWE1Cog0/mXqHsQIpJnlZK9W1wCwhhBZ2U/EHsRYg6wxAnisyyz xyKw== X-Gm-Message-State: AG10YOTszbpwmbrCCNGnXrImsA4xy5pRM1C7ljT6NUiQTUr4Shio6InNha63IBfOmj4CuA== X-Received: by 10.194.89.229 with SMTP id br5mr14496305wjb.5.1454688520698; Fri, 05 Feb 2016 08:08:40 -0800 (PST) Received: from donut.arnhem.chello.nl (178-84-161-31.dynamic.upc.nl. [178.84.161.31]) by smtp.gmail.com with ESMTPSA id b203sm8071254wmh.8.2016.02.05.08.08.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 05 Feb 2016 08:08:40 -0800 (PST) From: Wouter van Kesteren To: linux-fsdevel@vger.kernel.org Subject: [PATCH] fs: allow no_seek_end_llseek to actually seek Date: Fri, 5 Feb 2016 17:08:34 +0100 Message-Id: <1454688514-230665-1-git-send-email-woutershep@gmail.com> X-Mailer: git-send-email 2.7.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP '~0ULL' is a 'unsigned long long' that when converted to a loff_t, which is signed, gets turned into -1. later in vfs_setpos we have 'if (offset > maxsize)', which makes it always return EINVAL. Reviewed-by: Andreas Dilger --- fs/read_write.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/read_write.c b/fs/read_write.c index 324ec27..0c8782a 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -17,6 +17,7 @@ #include #include #include +#include #include "internal.h" #include @@ -183,7 +184,7 @@ loff_t no_seek_end_llseek(struct file *file, loff_t offset, int whence) switch (whence) { case SEEK_SET: case SEEK_CUR: return generic_file_llseek_size(file, offset, whence, - ~0ULL, 0); + OFFSET_MAX, 0); default: return -EINVAL; }