From patchwork Wed Jul 20 04:20:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 9238823 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 40C546077C for ; Wed, 20 Jul 2016 04:22:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 380911FF60 for ; Wed, 20 Jul 2016 04:22:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C9DA26C2F; Wed, 20 Jul 2016 04:22:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B1C8E1FF60 for ; Wed, 20 Jul 2016 04:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbcGTEVJ (ORCPT ); Wed, 20 Jul 2016 00:21:09 -0400 Received: from alt42.smtp-out.videotron.ca ([23.233.128.29]:4828 "EHLO alt42.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbcGTEUv (ORCPT ); Wed, 20 Jul 2016 00:20:51 -0400 Received: from yoda.home ([96.23.157.65]) by Videotron with SMTP id Pj03bwbT8cMN9Pj04bXD3h; Wed, 20 Jul 2016 00:20:48 -0400 X-Authority-Analysis: v=2.1 cv=YqOvP9sX c=1 sm=1 tr=0 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=KKAkSRfTAAAA:8 a=tBb2bbeoAAAA:8 a=R5CuANmm5DveqMR5uOoA:9 a=cvBusfyB2V15izCimMoJ:22 a=Oj-tNtZlA1e06AYgeCfH:22 Received: from xanadu.home (xanadu.home [192.168.2.2]) by yoda.home (Postfix) with ESMTP id 807D52DA069E; Wed, 20 Jul 2016 00:20:46 -0400 (EDT) From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH v3 10/12] binfmt_flat: update libraries' data segment pointer with userspace accessors Date: Wed, 20 Jul 2016 00:20:22 -0400 Message-Id: <1468988424-32671-11-git-send-email-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468988424-32671-1-git-send-email-nicolas.pitre@linaro.org> References: <1468988424-32671-1-git-send-email-nicolas.pitre@linaro.org> X-CMAE-Envelope: MS4wfFZdhZqucy0xniZYlE69aveMJXDSZfA4sNagwmEvKot05ychW9Z2JUWduDfRRP3119ncVn4rkE7EIfGuTc2/Ji/ZsruCJPRznfYP6ywTquoQgfu/uW8k NfxZnKH7W6+5EN+YUUWkh19W4b86fxi1Y9wQdSUHchYxDstB/k0eMLHvgjfJfV/GUw+7WfWS/JXS5Vx+fxYzR7laPsz29WLb5iJZSkXPQpHmv4V5TjUj1NXk Qlc2ki36anoHoIw1AnpGcANwM32gpt+KrM9Tje2i4vbG1JBPFH60iq6aZlAo4xyQpthXhXsfgP+RHLy1hCc8Yg== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is needed on systems with a MMU. This also gets rid of the strangest C code I've seen lateli i.e. an integer indexed with a pointer value within square brackets. That really looked backwards. Signed-off-by: Nicolas Pitre Reviewed-by: Greg Ungerer --- fs/binfmt_flat.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 0d89830f76..fef94aaa36 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -897,12 +897,19 @@ static int load_flat_binary(struct linux_binprm * bprm) return res; /* Update data segment pointers for all libraries */ - for (i=0; i