From patchwork Tue Sep 27 16:43:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kara X-Patchwork-Id: 9352327 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6796E6086A for ; Tue, 27 Sep 2016 16:44:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 58D042926D for ; Tue, 27 Sep 2016 16:44:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D08F292A2; Tue, 27 Sep 2016 16:44:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5965529297 for ; Tue, 27 Sep 2016 16:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934742AbcI0QoD (ORCPT ); Tue, 27 Sep 2016 12:44:03 -0400 Received: from mx2.suse.de ([195.135.220.15]:42399 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936212AbcI0Qnu (ORCPT ); Tue, 27 Sep 2016 12:43:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id EE512ABFC; Tue, 27 Sep 2016 16:43:43 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id C05021E10DC; Tue, 27 Sep 2016 18:43:42 +0200 (CEST) From: Jan Kara To: linux-fsdevel@vger.kernel.org Cc: linux-nvdimm@lists.01.org, Dan Williams , Ross Zwisler , Jan Kara Subject: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks() Date: Tue, 27 Sep 2016 18:43:33 +0200 Message-Id: <1474994615-29553-5-git-send-email-jack@suse.cz> X-Mailer: git-send-email 2.6.6 In-Reply-To: <1474994615-29553-1-git-send-email-jack@suse.cz> References: <1474994615-29553-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP So far we did not set BH_New for newly allocated blocks for DAX inodes in __xfs_get_blocks() because we wanted to avoid zeroing done in generic DAX code which was racy. Now the zeroing is gone so we can remove this workaround and return BH_New for newly allocated blocks. DAX will use this information to properly update mappings of the file. Signed-off-by: Jan Kara --- fs/xfs/xfs_aops.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 4a28fa91e3b1..b25b7b5a1e6e 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -1245,11 +1245,8 @@ __xfs_get_blocks( goto out_unlock; } - if (IS_DAX(inode) && create) { + if (IS_DAX(inode) && create) ASSERT(!ISUNWRITTEN(&imap)); - /* zeroing is not needed at a higher layer */ - new = 0; - } /* trim mapping down to size requested */ xfs_map_trim_size(inode, iblock, bh_result, &imap, offset, size);