From patchwork Mon Nov 7 10:51:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miklos Szeredi X-Patchwork-Id: 9414737 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CA80460512 for ; Mon, 7 Nov 2016 11:22:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAD5928B46 for ; Mon, 7 Nov 2016 11:22:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AF2EE28BBB; Mon, 7 Nov 2016 11:22:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5E1B828B46 for ; Mon, 7 Nov 2016 11:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbcKGLWm (ORCPT ); Mon, 7 Nov 2016 06:22:42 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36304 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbcKGLWl (ORCPT ); Mon, 7 Nov 2016 06:22:41 -0500 Received: by mail-wm0-f43.google.com with SMTP id p190so175901668wmp.1 for ; Mon, 07 Nov 2016 03:22:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g+duC2SiWlqznwnFzNhzGGryBJPepS40PfzVDJ92vpg=; b=JDfpvV6YRvTpTCrfjjJC++rn2k8/jZgwgtUtmU9sAqIKANEobyYXpwrTIuxllEXGKV yltguxX9tC672nfNNxuGLDz8o0+HlDN1qDn3WqbvE+ec5muT6vDe13PXLzoPUI1ZCi8M H5Uj8aJGUkWSy+xv66lZwi7rj+OC5a504bs1wGeh17ENsWSb/wT3EQcPyKzTZF4m3Yrk GLEEs+7VFlbhWxziTX55SXWRwlgPxd5wwE7g2M2z//wYSnP86O1RYluP9WIIpS1HQwDp zH0yiWwZZud8Wynkqr8Sk8YrOROJWjJCmXnUNrQ2AjCY85scvv63JwVI7GjXxGNgyGp5 l6bQ== X-Gm-Message-State: ABUngvcDdC5kzqGjBZpS8BYiYAqw9RmLmZNV0CmqrBsCT82o92+pxjrthUwSoe2UM0HdQ953 X-Received: by 10.194.119.162 with SMTP id kv2mr4747289wjb.182.1478515925910; Mon, 07 Nov 2016 02:52:05 -0800 (PST) Received: from veci.piliscsaba.szeredi.hu (pool-dsl-2c-0018.externet.hu. [217.173.44.24]) by smtp.gmail.com with ESMTPSA id 1sm12749496wmk.22.2016.11.07.02.52.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 02:52:05 -0800 (PST) From: Miklos Szeredi To: Al Viro Cc: Trond Myklebust , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] ncpfs: don't use ->d_time Date: Mon, 7 Nov 2016 11:51:59 +0100 Message-Id: <1478515920-20458-3-git-send-email-mszeredi@redhat.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1478515920-20458-1-git-send-email-mszeredi@redhat.com> References: <1478515920-20458-1-git-send-email-mszeredi@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Ncpfs stores a boolean value in ->d_fsdata as well as using d_time. Introcude ncp_dentry to store both of these and make d_fsdata point to it. Signed-off-by: Miklos Szeredi --- fs/ncpfs/dir.c | 21 ++++++++++++++++++--- fs/ncpfs/ncplib_kernel.h | 16 +++++++++++++--- 2 files changed, 31 insertions(+), 6 deletions(-) diff --git a/fs/ncpfs/dir.c b/fs/ncpfs/dir.c index 6df2a3827574..ce42dbdde777 100644 --- a/fs/ncpfs/dir.c +++ b/fs/ncpfs/dir.c @@ -72,6 +72,8 @@ const struct inode_operations ncp_dir_inode_operations = /* * Dentry operations routines */ +static int ncp_d_init(struct dentry *); +static void ncp_d_release(struct dentry *); static int ncp_lookup_validate(struct dentry *, unsigned int); static int ncp_hash_dentry(const struct dentry *, struct qstr *); static int ncp_compare_dentry(const struct dentry *, @@ -81,6 +83,8 @@ static void ncp_d_prune(struct dentry *dentry); const struct dentry_operations ncp_dentry_operations = { + .d_init = ncp_d_init, + .d_release = ncp_d_release, .d_revalidate = ncp_lookup_validate, .d_hash = ncp_hash_dentry, .d_compare = ncp_compare_dentry, @@ -305,6 +309,17 @@ leave_me:; } #endif /* CONFIG_NCPFS_STRONG */ +static int ncp_d_init(struct dentry *dentry) +{ + dentry->d_fsdata = kzalloc(sizeof(struct ncp_dentry), GFP_KERNEL); + + return dentry->d_fsdata ? 0 : -ENOMEM; +} + +static void ncp_d_release(struct dentry *dentry) +{ + kfree(dentry->d_fsdata); +} static int ncp_lookup_validate(struct dentry *dentry, unsigned int flags) @@ -408,7 +423,7 @@ ncp_invalidate_dircache_entries(struct dentry *parent) spin_lock(&parent->d_lock); list_for_each_entry(dentry, &parent->d_subdirs, d_child) { - dentry->d_fsdata = NULL; + NCP_DENTRY(dentry)->cached = false; ncp_age_dentry(server, dentry); } spin_unlock(&parent->d_lock); @@ -568,7 +583,7 @@ static int ncp_readdir(struct file *file, struct dir_context *ctx) static void ncp_d_prune(struct dentry *dentry) { - if (!dentry->d_fsdata) /* not referenced from page cache */ + if (!NCP_DENTRY(dentry)->cached) /* not referenced from page cache */ return; NCP_FINFO(d_inode(dentry->d_parent))->flags &= ~NCPI_DIR_CACHE; } @@ -659,7 +674,7 @@ ncp_fill_cache(struct file *file, struct dir_context *ctx, } if (ctl.cache) { if (d_really_is_positive(newdent)) { - newdent->d_fsdata = newdent; + NCP_DENTRY(newdent)->cached = true; ctl.cache->dentry[ctl.idx] = newdent; ino = d_inode(newdent)->i_ino; ncp_new_dentry(newdent); diff --git a/fs/ncpfs/ncplib_kernel.h b/fs/ncpfs/ncplib_kernel.h index 17cfb743b5bf..76459e4f6b64 100644 --- a/fs/ncpfs/ncplib_kernel.h +++ b/fs/ncpfs/ncplib_kernel.h @@ -168,20 +168,30 @@ static inline int ncp_strnicmp(const struct nls_table *t, #endif /* CONFIG_NCPFS_NLS */ -#define NCP_GET_AGE(dentry) (jiffies - (dentry)->d_time) +struct ncp_dentry { + unsigned long time; + bool cached; +}; + +static inline struct ncp_dentry *NCP_DENTRY(struct dentry *dentry) +{ + return (struct ncp_dentry *) dentry->d_fsdata; +} + +#define NCP_GET_AGE(dentry) (jiffies - NCP_DENTRY(dentry)->time) #define NCP_MAX_AGE(server) atomic_read(&(server)->dentry_ttl) #define NCP_TEST_AGE(server,dentry) (NCP_GET_AGE(dentry) < NCP_MAX_AGE(server)) static inline void ncp_age_dentry(struct ncp_server* server, struct dentry* dentry) { - dentry->d_time = jiffies - NCP_MAX_AGE(server); + NCP_DENTRY(dentry)->time = jiffies - NCP_MAX_AGE(server); } static inline void ncp_new_dentry(struct dentry* dentry) { - dentry->d_time = jiffies; + NCP_DENTRY(dentry)->time = jiffies; } struct ncp_cache_head {