diff mbox

Fs: Improvement in code readability when memdup_user()fails.

Message ID 1478854944-25969-1-git-send-email-sachin.s5@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Shukla Nov. 11, 2016, 9:02 a.m. UTC 
From: "Sachin Shukla"<sachin.s5@samsung.com)>

There is no need to call kfree() if memdup_user() fails, as no memory
was allocated and the error in the error-valued pointer should be returned.

Signed-off-by: Sachin Shukla <sachin.s5@samsung.com>
---
 fs/ioctl.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff mbox

Patch

diff --git a/fs/ioctl.c b/fs/ioctl.c
index c415668..1103c5d 100644
--- a/fs/ioctl.c
+++ b/fs/ioctl.c
@@ -588,11 +588,8 @@  static int ioctl_file_dedupe_range(struct file *file, void __user *arg)
 	}
 
 	same = memdup_user(argp, size);
-	if (IS_ERR(same)) {
-		ret = PTR_ERR(same);
-		same = NULL;
-		goto out;
-	}
+	if (IS_ERR(same))
+		return PTR_ERR(same);
 
 	same->dest_count = count;
 	ret = vfs_dedupe_file_range(file, same);