From patchwork Sat Apr 29 00:34:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Myungho Jung X-Patchwork-Id: 9705593 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C6713601D7 for ; Sat, 29 Apr 2017 00:34:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6DC82868E for ; Sat, 29 Apr 2017 00:34:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A1C6286AC; Sat, 29 Apr 2017 00:34:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 428312868E for ; Sat, 29 Apr 2017 00:34:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163714AbdD2Aen (ORCPT ); Fri, 28 Apr 2017 20:34:43 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36792 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162816AbdD2Aen (ORCPT ); Fri, 28 Apr 2017 20:34:43 -0400 Received: by mail-pf0-f195.google.com with SMTP id v14so19522411pfd.3 for ; Fri, 28 Apr 2017 17:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XCxbaxJf84LTUTjXVRRTY7lbG+A1mbud/hmmGWsc+44=; b=fhKCdP/r5dsajtg0KWi5hMh0LXRP/E3vKSr6/VZNHhousNJg5TeeZ8x0bigPGDr2xf EK4GzvaTWtXNBuhhbUiAKDxKfa7VxGch3dvNXKBemyTie2KGdSjGikFxwPehN2O4Y5g1 Wr/sN7KFQd4rjqilSMmG1tkbvL+YRGwqLRDv+lnh+9VgnWSeDyvJJKWhfVIrsWAHOERa qtMYKsX7dwzYuQ8apvQEQBWEjKe7pVrw0ItNE2OUmNLCVH91I6IxxE2Iz5BbIFjc2L4C aRkuMLi4FUfyLwKouWNejmL7znBYr+khsDfRdhhkJ4YpfaW8zC96JYpamLxPY/Rm8iZz CjOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XCxbaxJf84LTUTjXVRRTY7lbG+A1mbud/hmmGWsc+44=; b=nXxKv88A+RkUZRNDcx5lMhMXK1CQR31SlYMbIxwMQaszRaxjmXZRMhBmenyHzD8rha Mc0wKdC2sS3Vn/XeI6HlGn1uY+9TozfdjaeE0s0cYBCtpidjAt/rGc/PPHiRzrR4Gz+T GKG2OgDL+A9HuQzFtxozhhmabYUz8ZPwxX4xZkFCtOcjl+cFM0ZkYU1Hedoznj76rH9i RvZn4KdI21Ebz3T10ivETLTZg74fWWlccyguca+D9u3a6+SgkOUTrWgichOCUk4P+xCV UPqV9/KYVwfe0n1qOWMPseqlCkjOdo/SlNXOtI25kNMgrjM3OBdl5JlY9HlP7ZhaTHKg AAyw== X-Gm-Message-State: AN3rC/5juql7CsoKXF8Mva2GSLQwl8kN+rDUzxk1aBe3gJy6UJfYMa35 TN9SCXpZWY/ef6m0 X-Received: by 10.99.122.66 with SMTP id j2mr14283168pgn.129.1493426080186; Fri, 28 Apr 2017 17:34:40 -0700 (PDT) Received: from localhost (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id p6sm13730721pgn.9.2017.04.28.17.34.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Apr 2017 17:34:39 -0700 (PDT) From: Myungho Jung To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org Subject: [PATCH] fs: fix utimensat to properly return error code Date: Fri, 28 Apr 2017 17:34:41 -0700 Message-Id: <1493426081-22864-1-git-send-email-mhjungk@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP According to man utimensat(2), EACCES should be returned if the file is immutable and time values are null or UTIME_NOW. This is found by utimesat01 testcase in LTP. Signed-off-by: Myungho Jung --- fs/attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/attr.c b/fs/attr.c index 1353041..4c06aae 100644 --- a/fs/attr.c +++ b/fs/attr.c @@ -222,7 +222,7 @@ int notify_change(struct dentry * dentry, struct iattr * attr, struct inode **de */ if (ia_valid & ATTR_TOUCH) { if (IS_IMMUTABLE(inode)) - return -EPERM; + return -EACCES; if (!inode_owner_or_capable(inode)) { error = inode_permission(inode, MAY_WRITE);