diff mbox

FS: Making aproriate return type

Message ID 1494476049-16139-1-git-send-email-pushkar.iit@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

pjambhlekar May 11, 2017, 4:14 a.m. UTC 
unsigned_offsets function returns fmode_t but function definition returns int. sparse generate warning.
Updating proper return type

Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
 fs/read_write.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Al Viro May 11, 2017, 4:20 a.m. UTC | #1 
On Thu, May 11, 2017 at 09:44:09AM +0530, Pushkar Jambhlekar wrote:
> unsigned_offsets function returns fmode_t but function definition returns int. sparse generate warning.
> Updating proper return type

You do realize that it's a predicate?  This is actually one case where
bool would be appropriate...
diff mbox

Patch

diff --git a/fs/read_write.c b/fs/read_write.c
index 47c1d44..d11eabc 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -33,7 +33,7 @@  const struct file_operations generic_ro_fops = {
 
 EXPORT_SYMBOL(generic_ro_fops);
 
-static inline int unsigned_offsets(struct file *file)
+static inline fmode_t unsigned_offsets(struct file *file)
 {
 	return file->f_mode & FMODE_UNSIGNED_OFFSET;
 }