From patchwork Wed May 17 00:28:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Myungho Jung X-Patchwork-Id: 9729821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 76AA360138 for ; Wed, 17 May 2017 00:29:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A15228591 for ; Wed, 17 May 2017 00:29:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5ECF628734; Wed, 17 May 2017 00:29:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AFDEC286BE for ; Wed, 17 May 2017 00:29:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbdEQA3G (ORCPT ); Tue, 16 May 2017 20:29:06 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33965 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752000AbdEQA3F (ORCPT ); Tue, 16 May 2017 20:29:05 -0400 Received: by mail-pf0-f194.google.com with SMTP id w69so21607066pfk.1; Tue, 16 May 2017 17:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6Mo/BzwULbNtR8nkaeU5Ce4H0Q1kTL6sOFZ/HsR2nI8=; b=E64knEAAFSomExdCiS0UW247sDtOAzgrnOiUPs2mCZYBgzDJV5sm4sHzqwU6+Y2vPU mohErYmbesZp5l9VoqoT4Bm8mslaPxLQLY5V0dUA7z8TiGunFScro07v47j1sFWPdLMk ogvhS6SZ53oLhhIn2CHI2X4VaH/a1BJFRgmwBIHnbNVtWqpyIw9IfC5QqGzNsqCPnaBe Btq/oDsQLvEHXIEwAiHFdsU4YGXhV9fWXx1lhvKU1FPqsGkm0KJ1IZ/XIIMXrWPGQYtN tQ776XouPvCIno9TrlyfUDNEVDgo7UkQVY9K2/ApjTsb+5fOSci+/k5NDKbv50an9uQx PgGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6Mo/BzwULbNtR8nkaeU5Ce4H0Q1kTL6sOFZ/HsR2nI8=; b=B0pRg/uJyc/4rLev966aBOd+TLcltlDzi/7fZriJPocqhyTwpRgcChP0bc4Hr2ZGEy 70EzMQcQvXaxGZrNs5BT5Q4eZutFT/DDqKkQKfURxNzEKrHDhMXN4fUWgXIDpV651piw ST537JkhiFKKf45DRRrFh85GrvwWkPcokq+udl0WPdl/0ZLSIsO38TYgRXdTxXY9FLyt QieqZr0pxtaBc7vnL2+9ox7kNk+G/htqe9yVPNQElj+wc6KwjuuV73Hn5bsD/lPVW8NU Dkv5owqt7N7K/U5POKSCp70Oh6G0PWeXSYHH0ijChef9wv4L+vpvuUjzcYr8scXzVfHW Qw+w== X-Gm-Message-State: AODbwcDYbK70NymFDnOVZd00IetXXsOFCmJkwnNSgSDs0h6i1XVGTHIm VvPp3h0x4s0fYhUt X-Received: by 10.98.193.129 with SMTP id i123mr733369pfg.203.1494980944310; Tue, 16 May 2017 17:29:04 -0700 (PDT) Received: from localhost (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id c12sm325028pgn.21.2017.05.16.17.29.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 May 2017 17:29:03 -0700 (PDT) From: Myungho Jung To: viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] fs: fix utimensat to return correct error code Date: Tue, 16 May 2017 17:28:55 -0700 Message-Id: <1494980935-6926-1-git-send-email-mhjungk@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP According to man utimensat(2), EACCES should be returned if the file is immutable and time values are null or UTIME_NOW. Testcase is utimesat01/LTP. Signed-off-by: Myungho Jung --- fs/attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/attr.c b/fs/attr.c index 1353041..4c06aae 100644 --- a/fs/attr.c +++ b/fs/attr.c @@ -222,7 +222,7 @@ int notify_change(struct dentry * dentry, struct iattr * attr, struct inode **de */ if (ia_valid & ATTR_TOUCH) { if (IS_IMMUTABLE(inode)) - return -EPERM; + return -EACCES; if (!inode_owner_or_capable(inode)) { error = inode_permission(inode, MAY_WRITE);