From patchwork Mon May 22 09:58:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Brandenburg X-Patchwork-Id: 9741383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B33446034C for ; Mon, 22 May 2017 21:00:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A64BC2875E for ; Mon, 22 May 2017 21:00:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9B47128760; Mon, 22 May 2017 21:00:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=2.0 tests=BAYES_00, DATE_IN_PAST_06_12, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45D0D2875E for ; Mon, 22 May 2017 21:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762661AbdEVVAj (ORCPT ); Mon, 22 May 2017 17:00:39 -0400 Received: from mail-qt0-f182.google.com ([209.85.216.182]:34762 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762653AbdEVVA0 (ORCPT ); Mon, 22 May 2017 17:00:26 -0400 Received: by mail-qt0-f182.google.com with SMTP id c13so112315458qtc.1 for ; Mon, 22 May 2017 14:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=omnibond-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M2TSojO8vRwJMPfnGw5JEMYxeM4gRNDxV/2qyXJQzKI=; b=VP8kQnfDiInRLPrtyRLGPWEwkO7HFQCfIl6CtafeMhDaWHRZUq1W9QpvxRW7WqN7FG Q6qcJexs2+9RFxePZXhtcDYwUD9bscH+tYlB7TO6uzkLmTFhpRFEioFQyF4qCW/1W0dX MvfGqsaI45RuvWHYOntOV47zYMC3LTHJB2A5XYu3xFIbElH90WXtEzQamhg7mi2tP/OT zmaqJx4Zbd1S/no0nvglsJkAhwthQxAk+j6Mk9wFTbwZ31yIt2pw5fRYmF/oxJSxnMS3 lNU7zNLoTnwTIuv3qvkuMDx87HVmYca4d4bbEur+v5OoNo9WUJhPYJgbJuzrulcMg/V+ VDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M2TSojO8vRwJMPfnGw5JEMYxeM4gRNDxV/2qyXJQzKI=; b=qcy4AoN66INe212nB0XMyKowqAiJLLVN6s6+MN/kQ8w7nguPGbVbLPQL/c7PLw0U7v Kd6ncbg/3V+ZaUHyx9WYEgyGE0Hw262+rQZvBYIeDAgdOG4eMQZUiit+MkYi0O1U8ccF Z9dcQ1qVitd805n7sGUHjGmYb9Q2XIncGNzYQHbgEG4ksSr3awB1rlDnC8lfAeIwmt/U QA+ACsdhywnjI3Oj74g3060+uLKGRK0iabKYkHU1OwrgRHTGEAHtuJaesTnPC3ZuoXj7 Mjy5Y1WEwGj0PvDJkBdFZdoEm1AD+wXUXPaVI5N2NnB52sboajK0ramhiJ7VWMJIy63U kWgg== X-Gm-Message-State: AODbwcBiKRCjsOY+IzebEgzm9BmXvcija9KxBCWXRuUA8SgD9DX/mDWO xyJjkOlkewGVDlbJ X-Received: by 10.200.1.142 with SMTP id x14mr25872807qtf.26.1495486814225; Mon, 22 May 2017 14:00:14 -0700 (PDT) Received: from mkbserver1.clemson.edu ([130.127.148.244]) by smtp.gmail.com with ESMTPSA id z203sm12740113qkb.46.2017.05.22.14.00.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 May 2017 14:00:13 -0700 (PDT) From: Martin Brandenburg To: hubcap@omnibond.com, linux-fsdevel@vger.kernel.org Cc: Martin Brandenburg Subject: [PATCH 05/13] orangefs: BUG_ON if i_mode invalid Date: Mon, 22 May 2017 05:58:53 -0400 Message-Id: <1495447141-12216-6-git-send-email-martin@omnibond.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1495447141-12216-1-git-send-email-martin@omnibond.com> References: <1495447141-12216-1-git-send-email-martin@omnibond.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This can't happen since it would have been caught (and a graceful error returned) earlier. Signed-off-by: Martin Brandenburg --- fs/orangefs/inode.c | 14 ++++---------- fs/orangefs/orangefs-utils.c | 4 ++++ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c index a9681b0..9912104 100644 --- a/fs/orangefs/inode.c +++ b/fs/orangefs/inode.c @@ -175,22 +175,16 @@ static int orangefs_init_iops(struct inode *inode) inode->i_fop = &orangefs_file_operations; inode->i_data.a_ops = &orangefs_address_operations; inode->i_blkbits = PAGE_SHIFT; - break; + return 0; case S_IFLNK: inode->i_op = &orangefs_symlink_inode_operations; - break; + return 0; case S_IFDIR: inode->i_op = &orangefs_dir_inode_operations; inode->i_fop = &orangefs_dir_operations; - break; - default: - gossip_debug(GOSSIP_INODE_DEBUG, - "%s: unsupported mode\n", - __func__); - return -EINVAL; + return 0; } - - return 0; + BUG_ON(1); } /* diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c index aab6f18..1fb90bd 100644 --- a/fs/orangefs/orangefs-utils.c +++ b/fs/orangefs/orangefs-utils.c @@ -294,6 +294,10 @@ int orangefs_inode_getattr(struct inode *inode, int new, int bypass, type = orangefs_inode_type(new_op-> downcall.resp.getattr.attributes.objtype); + if (type == -1) { + ret = -EIO; + goto out; + } ret = orangefs_inode_is_stale(inode, new, &new_op->downcall.resp.getattr.attributes, new_op->downcall.resp.getattr.link_target);