Message ID | 1499339134-104480-1-git-send-email-yunlong.song@huawei.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Yunlong, It looks there is no way to create discard thread redundantly, so here we don't need to check this? Thanks, On 2017/7/6 19:05, Yunlong Song wrote: > Signed-off-by: Yunlong Song <yunlong.song@huawei.com> > --- > fs/f2fs/segment.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 4c246e3..b48d004 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -1417,6 +1417,8 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi) > > if (SM_I(sbi)->dcc_info) { > dcc = SM_I(sbi)->dcc_info; > + if (dcc->f2fs_issue_discard) > + return err; > goto init_thread; > } > >
It's fine unless create_discard_cmd_control is used in remount flow in the future. On 2017/7/6 21:16, Chao Yu wrote: > Hi Yunlong, > > It looks there is no way to create discard thread redundantly, > so here we don't need to check this? > > Thanks, > > On 2017/7/6 19:05, Yunlong Song wrote: >> Signed-off-by: Yunlong Song <yunlong.song@huawei.com> >> --- >> fs/f2fs/segment.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index 4c246e3..b48d004 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -1417,6 +1417,8 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi) >> >> if (SM_I(sbi)->dcc_info) { >> dcc = SM_I(sbi)->dcc_info; >> + if (dcc->f2fs_issue_discard) >> + return err; >> goto init_thread; >> } >> >> > . >
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 4c246e3..b48d004 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1417,6 +1417,8 @@ static int create_discard_cmd_control(struct f2fs_sb_info *sbi) if (SM_I(sbi)->dcc_info) { dcc = SM_I(sbi)->dcc_info; + if (dcc->f2fs_issue_discard) + return err; goto init_thread; }
Signed-off-by: Yunlong Song <yunlong.song@huawei.com> --- fs/f2fs/segment.c | 2 ++ 1 file changed, 2 insertions(+)