| Message ID | 1505850787-18311-4-git-send-email-axboe@kernel.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 19, 2017 at 01:53:04PM -0600, Jens Axboe wrote: > Laptop mode really wants to writeback the number of dirty > pages and inodes. Instead of calculating this in the caller, > just pass in 0 and let wakeup_flusher_threads() handle it. > > Use the new wakeup_flusher_threads_bdi() instead of rolling > our own. > > Signed-off-by: Jens Axboe <axboe@kernel.dk> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
On Tue 19-09-17 13:53:04, Jens Axboe wrote: > Laptop mode really wants to writeback the number of dirty > pages and inodes. Instead of calculating this in the caller, > just pass in 0 and let wakeup_flusher_threads() handle it. > > Use the new wakeup_flusher_threads_bdi() instead of rolling > our own. > > Signed-off-by: Jens Axboe <axboe@kernel.dk> ... > - rcu_read_lock(); > - list_for_each_entry_rcu(wb, &q->backing_dev_info->wb_list, bdi_node) > - if (wb_has_dirty_io(wb)) > - wb_start_writeback(wb, nr_pages, true, > - WB_REASON_LAPTOP_TIMER); > - rcu_read_unlock(); > + wakeup_flusher_threads_bdi(q->backing_dev_info, 0, > + WB_REASON_LAPTOP_TIMER); > } So this slightly changes the semantics since previously we were doing range_cyclic writeback and now we don't. I don't think this matters in practice but please mention that in the changelog. With that you can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza
On 09/20/2017 08:35 AM, Jan Kara wrote: > On Tue 19-09-17 13:53:04, Jens Axboe wrote: >> Laptop mode really wants to writeback the number of dirty >> pages and inodes. Instead of calculating this in the caller, >> just pass in 0 and let wakeup_flusher_threads() handle it. >> >> Use the new wakeup_flusher_threads_bdi() instead of rolling >> our own. >> >> Signed-off-by: Jens Axboe <axboe@kernel.dk> > ... >> - rcu_read_lock(); >> - list_for_each_entry_rcu(wb, &q->backing_dev_info->wb_list, bdi_node) >> - if (wb_has_dirty_io(wb)) >> - wb_start_writeback(wb, nr_pages, true, >> - WB_REASON_LAPTOP_TIMER); >> - rcu_read_unlock(); >> + wakeup_flusher_threads_bdi(q->backing_dev_info, 0, >> + WB_REASON_LAPTOP_TIMER); >> } > > So this slightly changes the semantics since previously we were doing > range_cyclic writeback and now we don't. I don't think this matters in > practice but please mention that in the changelog. With that you can add: Thanks, I added a note about that in the commit message.
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 0b9c5cbe8eba..1933778c52c4 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -1980,23 +1980,9 @@ int dirty_writeback_centisecs_handler(struct ctl_table *table, int write, void laptop_mode_timer_fn(unsigned long data) { struct request_queue *q = (struct request_queue *)data; - int nr_pages = global_node_page_state(NR_FILE_DIRTY) + - global_node_page_state(NR_UNSTABLE_NFS); - struct bdi_writeback *wb; - /* - * We want to write everything out, not just down to the dirty - * threshold - */ - if (!bdi_has_dirty_io(q->backing_dev_info)) - return; - - rcu_read_lock(); - list_for_each_entry_rcu(wb, &q->backing_dev_info->wb_list, bdi_node) - if (wb_has_dirty_io(wb)) - wb_start_writeback(wb, nr_pages, true, - WB_REASON_LAPTOP_TIMER); - rcu_read_unlock(); + wakeup_flusher_threads_bdi(q->backing_dev_info, 0, + WB_REASON_LAPTOP_TIMER); } /*
Laptop mode really wants to writeback the number of dirty pages and inodes. Instead of calculating this in the caller, just pass in 0 and let wakeup_flusher_threads() handle it. Use the new wakeup_flusher_threads_bdi() instead of rolling our own. Signed-off-by: Jens Axboe <axboe@kernel.dk> --- mm/page-writeback.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-)