| Message ID | 1506543239-31470-6-git-send-email-axboe@kernel.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed 27-09-17 14:13:52, Jens Axboe wrote: > We're writing back the full range of dirty pages on the devices, > there's no point in making this special and not do normal range > cyclic writeback. > > Signed-off-by: Jens Axboe <axboe@kernel.dk> OK, since this is just ordinary "memory cleaning" writeback, I agree that range_cyclic probably makes more sense. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/fs-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index bb6148dc6d24..65e6992d8719 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -1971,7 +1971,7 @@ void wakeup_flusher_threads(enum wb_reason reason) > > list_for_each_entry_rcu(wb, &bdi->wb_list, bdi_node) > wb_start_writeback(wb, wb_split_bdi_pages(wb, nr_pages), > - false, reason); > + true, reason); > } > rcu_read_unlock(); > } > -- > 2.7.4 >
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index bb6148dc6d24..65e6992d8719 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1971,7 +1971,7 @@ void wakeup_flusher_threads(enum wb_reason reason) list_for_each_entry_rcu(wb, &bdi->wb_list, bdi_node) wb_start_writeback(wb, wb_split_bdi_pages(wb, nr_pages), - false, reason); + true, reason); } rcu_read_unlock(); }
We're writing back the full range of dirty pages on the devices, there's no point in making this special and not do normal range cyclic writeback. Signed-off-by: Jens Axboe <axboe@kernel.dk> --- fs/fs-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)