diff mbox

fs: make fiemap work from compat_ioctl

Message ID 1506713046-19299-1-git-send-email-jbacik@fb.com (mailing list archive)
State New, archived
Headers show

Commit Message

Josef Bacik Sept. 29, 2017, 7:24 p.m. UTC
We don't need to do anything special with fiemap to make it work with a
64bit kernel from 32bit userspace, so just go down to do_vfs_ioctl().
Without this patch we were incorrectly failing to do fiemap with a 32bit
userspace on a 64bit kernel.

Signed-off-by: Josef Bacik <jbacik@fb.com>
---
 fs/compat_ioctl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Oct. 1, 2017, 8:22 a.m. UTC | #1
On Fri, Sep 29, 2017 at 03:24:06PM -0400, Josef Bacik wrote:
> We don't need to do anything special with fiemap to make it work with a
> 64bit kernel from 32bit userspace, so just go down to do_vfs_ioctl().
> Without this patch we were incorrectly failing to do fiemap with a 32bit
> userspace on a 64bit kernel.
> 
> Signed-off-by: Josef Bacik <jbacik@fb.com>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox

Patch

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index d27b326d96f4..480f9366b4e3 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1579,6 +1579,7 @@  COMPAT_SYSCALL_DEFINE3(ioctl, unsigned int, fd, unsigned int, cmd,
 	case FICLONE:
 	case FICLONERANGE:
 	case FIDEDUPERANGE:
+	case FS_IOC_FIEMAP:
 		goto do_ioctl;
 
 	case FIBMAP: