diff mbox

[1/2] vfs: stop clearing close on exec when closing a fd

Message ID 1507028295-9353-2-git-send-email-mguzik@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mateusz Guzik Oct. 3, 2017, 10:58 a.m. UTC 
Codepaths allocating a fd always make sure the bit is set/unset
depending on flags, thus clearing on close is redundant.

Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
---
 fs/file.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Eric Dumazet Oct. 3, 2017, 2:39 p.m. UTC | #1 
On Tue, Oct 3, 2017 at 3:58 AM, Mateusz Guzik <mguzik@redhat.com> wrote:
> Codepaths allocating a fd always make sure the bit is set/unset
> depending on flags, thus clearing on close is redundant.
>
> Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@google.com>
diff mbox

Patch

diff --git a/fs/file.c b/fs/file.c
index 1fc7fbb..9d047bd 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -631,7 +631,6 @@  int __close_fd(struct files_struct *files, unsigned fd)
 	if (!file)
 		goto out_unlock;
 	rcu_assign_pointer(fdt->fd[fd], NULL);
-	__clear_close_on_exec(fd, fdt);
 	__put_unused_fd(files, fd);
 	spin_unlock(&files->file_lock);
 	return filp_close(file, files);